dashboard/templates: Remove graphs from jobs-job{-branch} templates

[patersonc]

In the job// and job// views we often get a "Error
loading test data" error for the test pass rate graph at the bottom of the
page.

When viewing an entire tree at this level the build/test pass rate graphs
don't provide any useful information anyway, so let's just remove them.

If anyone manages to work out what is causing the issues in future we can
always restore one or both of the graphs again.

Signed-off-by: Chris Paterson [email protected]

[gctucker]

Please also remove the Javascript code that sends requests to the backend to populate these graphs, otherwise they'll keep doing it and just discarding the data.

$ git grep build-pass-rate
app/dashboard/static/js/app/view-jobs-job-branch.2020.10.js:            document.getElementById('build-pass-rate'),
app/dashboard/static/js/app/view-jobs-job-branch.2020.10.js:        chart.buildpassrate('build-pass-rate', response);
app/dashboard/static/js/app/view-jobs-job-branch.2020.10.js:                document.getElementById('build-pass-rate'),
app/dashboard/static/js/app/view-jobs-job.2020.10.js:            document.getElementById('build-pass-rate'),
app/dashboard/static/js/app/view-jobs-job.2020.10.js:        chart.buildpassrate('build-pass-rate', response);
app/dashboard/static/js/app/view-jobs-job.2020.10.js:                document.getElementById('build-pass-rate'),

Same for test-pass-rate.

[patersonc]

Hi @gctucker

Please also remove the Javascript code that sends requests to the backend to populate these graphs, otherwise they'll keep doing it and just discarding the data.

$ git grep build-pass-rate
app/dashboard/static/js/app/view-jobs-job-branch.2020.10.js:            document.getElementById('build-pass-rate'),
app/dashboard/static/js/app/view-jobs-job-branch.2020.10.js:        chart.buildpassrate('build-pass-rate', response);
app/dashboard/static/js/app/view-jobs-job-branch.2020.10.js:                document.getElementById('build-pass-rate'),
app/dashboard/static/js/app/view-jobs-job.2020.10.js:            document.getElementById('build-pass-rate'),
app/dashboard/static/js/app/view-jobs-job.2020.10.js:        chart.buildpassrate('build-pass-rate', response);
app/dashboard/static/js/app/view-jobs-job.2020.10.js:                document.getElementById('build-pass-rate'),

Same for test-pass-rate.

Thank you for pointing this out.

I've gone through and (hopefully) removed the relevant code.

Let me know if you also think charts/passrate.js should be removed. I kept it in case someone wants to use it elsewhere in future.

[gctucker]

Adding staging-skip label as this seems to be causing some issues on staging.

[patersonc]

Adding staging-skip label as this seems to be causing some issues on staging.

Sorry! Do you have any logs I can look through to work out what went wrong?

[gctucker]

No I just noticed that the frontend was failing to load some data and spinning for ever. I think that should be reproducible locally, but make sure you enable developer mode in your browser and disable all caches and force-reload the pages to get the actual Javascript changes. The developer mode should also show you all the queries that the frontend is doing and which ones are failing.