Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Implement the deprecated ctc_decode function in Keras v3 #19227

Closed
lpizzinidev opened this issue Feb 25, 2024 · 4 comments
Closed

(feat) Implement the deprecated ctc_decode function in Keras v3 #19227

lpizzinidev opened this issue Feb 25, 2024 · 4 comments
Assignees
Labels
stat:contributions welcome A pull request to fix this issue would be welcome. type:feature The user is asking for a new feature.

Comments

@lpizzinidev
Copy link
Contributor

What

Implement the deprecated ctc_decode function in keras.losses and make it backend-agnostic.

To achieve this we'll need to implement the following functions in keras.ops.nn:

After the implementation, update the related Automatic Speech Recognition using CTC example on the keras-io repo and make it compatible with all backends, if possible.

Results

  • The tf.nn.ctc_greedy_decoder function is implemented in keras.ops.nn with related test coverage
  • The tf.compat.v1.nn.ctc_beam_search_decoder function is implemented in keras.ops.nn with related test coverage
  • The ctc_decode function is implemented in keras.losses with related test coverage
  • The Automatic Speech Recognition using CTC example is updated with the new ctc_decode function and compatible with all backends
@sachinprasadhs sachinprasadhs added type:feature The user is asking for a new feature. keras-team-review-pending Pending review by a Keras team member. labels Feb 26, 2024
@fchollet fchollet added the stat:contributions welcome A pull request to fix this issue would be welcome. label Feb 27, 2024
@divyashreepathihalli
Copy link
Collaborator

@lpizzinidev are you interested in contributing a PR for this issue?

@lpizzinidev
Copy link
Contributor Author

@divyashreepathihalli
Sure 👍
I'm working on a PR for migrating a keras-io example to v3.
Once that's pushed I'll pick up this one ✅

@divyashreepathihalli divyashreepathihalli removed the keras-team-review-pending Pending review by a Keras team member. label Feb 29, 2024
@fchollet
Copy link
Member

This is being implemented in #19366

@sachinprasadhs
Copy link
Collaborator

Closing the issue as it is already implemented in the above linked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:contributions welcome A pull request to fix this issue would be welcome. type:feature The user is asking for a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants