Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tensorflow.keras.utils.plot_model not working correctly with show_shapes=True #16090

Closed
RicardFos opened this issue Feb 18, 2022 · 5 comments
Closed

tensorflow.keras.utils.plot_model not working correctly with show_shapes=True #16090

RicardFos opened this issue Feb 18, 2022 · 5 comments
Assignees
@RicardFos
Labels
stat:awaiting response from contributor type:feature The user is asking for a new feature.

Comments

@RicardFos
Copy link
Contributor

RicardFos commented Feb 18, 2022 •
edited
Loading

Hi, I've just used the tf.keras.utils.plot_model with tensorflow 2.8.0 and the following diagram appeared:
image

As you can see, the right part of the diagram shows the input and output shapes with a vertical split, but it should be an horizontal split to fit with the "intput:" and "output:" cells at its left.
@jvishnuvardhan jvishnuvardhan self-assigned this Feb 18, 2022
@jvishnuvardhan jvishnuvardhan added the type:feature The user is asking for a new feature. label Feb 18, 2022
@jvishnuvardhan
Copy link
Contributor

@RicardFos This is not a bug, so I added a feature request label. Are you interested working on it? Thanks!

@RicardFos
Copy link
Contributor Author

RicardFos commented Feb 19, 2022 •
edited
Loading

@jvishnuvardhan I could work on it, no problem!

@RicardFos RicardFos mentioned this issue Feb 19, 2022
Merged
@jvishnuvardhan jvishnuvardhan added keras-team-review-pending Pending review by a Keras team member. and removed stat:awaiting response from contributor labels Feb 23, 2022
@mattdangerw mattdangerw removed the keras-team-review-pending Pending review by a Keras team member. label Feb 24, 2022
@mattdangerw
Copy link
Member

Assigning this to you @RicardFos as it looks like you are actively working on this and the conversation has moved to the PR #16096. Thanks for contributing!

@jvishnuvardhan
Copy link
Contributor

@RicardFos This was resolved in recent tf-nightly by your PR as it got merged. Here is a gist for reference.

Please verify once and close the issue if this was resolved for you. Thanks!

@RicardFos
Copy link
Contributor Author

Thanks, I've checked the notebook and it works correctly, I'll mark this issue as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RicardFos RicardFos

Labels
stat:awaiting response from contributor type:feature The user is asking for a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattdangerw @RicardFos @jvishnuvardhan