Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: conditionally trigger GitHub Actions when needed #898

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

sudiptob2
Copy link
Member

Fixes #897

@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for keptn-lifecyle-testing ready!

Name Link
🔨 Latest commit d7cf182
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecyle-testing/deploys/63f5f3c675fbb300080ba3e1
😎 Deploy Preview https://deploy-preview-898--keptn-lifecyle-testing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sudiptob2 sudiptob2 marked this pull request as ready for review February 22, 2023 10:39
@sudiptob2 sudiptob2 marked this pull request as draft February 22, 2023 10:42
@sudiptob2 sudiptob2 changed the title ci: Conditionally trigger GitHub Actions when needed ci: conditionally trigger GitHub Actions when needed Feb 22, 2023
@sudiptob2 sudiptob2 marked this pull request as ready for review February 22, 2023 10:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #898 (d7cf182) into main (2fa1a02) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
+ Coverage   58.59%   58.60%   +0.01%     
==========================================
  Files          97       97              
  Lines        7552     7552              
==========================================
+ Hits         4425     4426       +1     
+ Misses       2936     2935       -1     
  Partials      191      191              
Impacted Files Coverage Δ
...ator/controllers/lifecycle/keptntask/controller.go 54.94% <0.00%> (-3.30%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 82.95% <0.00%> (+1.79%) ⬆️
Flag Coverage Δ
component-tests 42.20% <ø> (+0.54%) ⬆️
keptn-lifecycle-operator 54.67% <ø> (ø)
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mowies
Copy link
Member

mowies commented Feb 22, 2023

thanks @sudiptob2 , will merge now

@mowies mowies merged commit ba700a7 into keptn:main Feb 22, 2023
Amishakumari544 pushed a commit to Amishakumari544/lifecycle-toolkit that referenced this pull request Feb 27, 2023
aepfli pushed a commit to aepfli/lifecycle-toolkit that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditionally trigger GitHub Actions when needed
4 participants