-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: change port for KTL docs #713
docs: change port for KTL docs #713
Conversation
3f3d005
to
4037aa2
Compare
Yes, this is correct, but it renders the user with another problem if they use the makefile to start the server - because Hugo thinks it still runs on port 1313 within the docker container and prints this information to the user. We would also need to adapt the port for Hugo, so Hugo itself within the container is starting on the same port. Otherwise, the user experience will suffer, and finding out which port to use will be hard. As you seem like a curious person, I won't immediately post the solution :) Sometimes it is fun to figure things out on your own. But I can provide you with the necessary steps if needed. |
@aepfli thanks for giving the hint. I will try to investigate myself and hope to find the solution ✔️ |
…tn docs (keptn#708) Signed-off-by: Sudipto Baral <[email protected]>
…t where the server is running (keptn#708) Signed-off-by: Sudipto Baral <[email protected]>
57aad32
to
acbbfb9
Compare
@aepfli , I just updated the internal port of Hugo. Could you comment on the new changes, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect - thank you for the contribution
the only thing, we could theoretically improve is to extract this port number to a variable, so it is easier to change :)
Thanks for reviewing and approving the PR
I will update the code to accommodate this improvement also. |
Signed-off-by: Sudipto Baral <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi, @aepfli thanks for approving the PR. This PR seems ready to be merged. Please let me know if I have to do anything from my end. |
I sadly do not have more powers than you have within this repository, maybe @thisthat @StackScribe or @StackScribe can help? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
==========================================
+ Coverage 57.33% 57.36% +0.02%
==========================================
Files 88 88
Lines 7001 7001
==========================================
+ Hits 4014 4016 +2
+ Misses 2821 2820 -1
+ Partials 166 165 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
KTL docs port changes so that id does not conflict with the keptn docs (#708)
Example:
make PORT=1319 server