Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move crd template to CRD YAML Reference #1876

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

ShivangShandilya
Copy link
Contributor

This PR fixes - #1858

In this PR, crd template which was in the wrong menu, was moved in CRD YAML Reference

Reference: https://lifecycle.keptn.sh/docs/crd-ref/crd-template/

Signed-off-by: ShivangShandilya <[email protected]>
@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 7ed372e
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64d5225d3b2841000748b8b7
😎 Deploy Preview https://deploy-preview-1876--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ShivangShandilya 🥇 , can you please make a cherry pick and also push the change towards main, so that we can keep it in next docs versions?

@ShivangShandilya
Copy link
Contributor Author

Thank you @ShivangShandilya 1st_place_medal , can you please make a cherry pick and also push the change towards main, so that we can keep it in next docs versions?

Sure @RealAnna but looks like crd template is not available in main. So, I'll have to create this file in crd yaml ref. Do you want me to raise an issue for this or I can directly open up a PR directing it towards this very same issue?

@RealAnna
Copy link
Contributor

@ShivangShandilya, this is curious.... yes please use the same issue 😺

@thisthat thisthat merged commit d5837a2 into keptn:page Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants