Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fill in chart README #987

Merged
merged 6 commits into from
Mar 7, 2023
Merged

feat: fill in chart README #987

merged 6 commits into from
Mar 7, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Mar 7, 2023

this PR

  • adds data to helm chart README
  • forces validation pipeline to have all image TAG to refer to the next version of the chart to be released

@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 43a18af
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64070a90ef708700085b6caf
😎 Deploy Preview https://deploy-preview-987--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #987 (247d780) into main (444ba74) will increase coverage by 0.15%.
The diff coverage is n/a.

❗ Current head 247d780 differs from pull request most recent head 3002da3. Consider uploading reports for the commit 3002da3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
+ Coverage   57.38%   57.54%   +0.15%     
==========================================
  Files         119      120       +1     
  Lines        9914     9993      +79     
==========================================
+ Hits         5689     5750      +61     
- Misses       4027     4039      +12     
- Partials      198      204       +6     
Impacted Files Coverage Δ
...ptnworkloadinstance/reconcile_prepostdeployment.go 81.81% <0.00%> (-9.10%) ⬇️
...ator/controllers/lifecycle/keptntask/controller.go 54.94% <0.00%> (-3.30%) ⬇️
.../controllers/lifecycle/keptnworkload/controller.go 67.08% <0.00%> (ø)
operator/controllers/common/evaluationhandler.go 79.71% <0.00%> (+2.17%) ⬆️
...lers/lifecycle/keptnworkloadinstance/controller.go 81.16% <0.00%> (+2.24%) ⬆️
...ptnworkloadinstance/reconcile_prepostevaluation.go 90.90% <0.00%> (+18.18%) ⬆️
Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 51.92% <ø> (+2.47%) ⬆️
lifecycle-operator 53.63% <ø> (ø)
metrics-operator 62.98% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 2321180 into main Mar 7, 2023
@RealAnna RealAnna deleted the feat/complete_chart_readme branch March 7, 2023 14:37
@keptn-bot keptn-bot mentioned this pull request Mar 7, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants