Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adapt KeptnEvaluationDefinition and introduce KeptnMetricsProvider #944

Merged
merged 19 commits into from
Mar 6, 2023
Merged

docs: adapt KeptnEvaluationDefinition and introduce KeptnMetricsProvider #944

merged 19 commits into from
Mar 6, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Mar 1, 2023

Fixes: #882

@odubajDT odubajDT changed the title docs: splitting operator to klt-operator and metrics-operator docs: adapt KeptnEvaluationDefinition and introduce KeptnMetricsProvider Mar 1, 2023
StackScribe
StackScribe reviewed Mar 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe previously approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! I left some word-smithing suggestions for you to consider.

@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.0% 3.0% Duplication

@odubajDT
Copy link
Contributor Author

odubajDT commented Mar 1, 2023

Nicely done! I left some word-smithing suggestions for you to consider.

Thank you :) added your requested changes

@aepfli aepfli added the documentation Improvements or additions to documentation label Mar 1, 2023
@odubajDT odubajDT requested a review from StackScribe March 2, 2023 11:28
StackScribe
StackScribe reviewed Mar 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Mar 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
odubajDT and others added 12 commits March 6, 2023 08:45
@odubajDT
Update README.md
31f09ce 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT
Update README.md
4d66836 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT
Update README.md
0c6aad7 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT
Update README.md
73f00c0 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT
Update README.md
1497d02 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT
Update README.md
683f04c 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT
Update README.md
93e425b 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fix
9d81b91 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fix docs
5dd750f 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
Update README.md
417f64c 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fix docs
f28cfa4 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
add link to migration docs
5a7838e 
Signed-off-by: odubajDT <[email protected]>
@netlify
Copy link

netlify bot commented Mar 6, 2023

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 5a7838e
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64059b1ec2711e0008be0060
😎 Deploy Preview https://deploy-preview-944--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odubajDT odubajDT requested a review from StackScribe March 6, 2023 09:19
mowies
mowies reviewed Mar 6, 2023
View reviewed changes
README.md Show resolved Hide resolved
mowies
mowies previously approved these changes Mar 6, 2023
View reviewed changes
bacherfl
bacherfl reviewed Mar 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
bacherfl
bacherfl reviewed Mar 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@odubajDT @bacherfl
Update README.md
5c0cfa0 
Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT @bacherfl
Update README.md
92d3003 
Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@odubajDT odubajDT merged commit d56bfa4 into keptn:main Mar 6, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 6, 2023
Merged
This was referenced Mar 7, 2023
Closed
Closed
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowies mowies mowies approved these changes

@bacherfl bacherfl bacherfl approved these changes

@thisthat thisthat Awaiting requested review from thisthat

@thschue thschue Awaiting requested review from thschue

@StackScribe StackScribe Awaiting requested review from StackScribe

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt KeptnEvaluationDefinition to reflect changes in KeptnMetric and KeptnMetricsProvider
5 participants
@odubajDT @bacherfl @StackScribe @mowies @aepfli