-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add htmltest verification for documentation #932
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #932 +/- ##
==========================================
+ Coverage 58.02% 58.62% +0.60%
==========================================
Files 89 97 +8
Lines 7076 7556 +480
==========================================
+ Hits 4106 4430 +324
- Misses 2821 2935 +114
- Partials 149 191 +42
Flags with carried forward coverage won't be shown. Click here to find out more. |
Fixed HTMLTest make target, and added a verification step for GitHub Actions. Signed-off-by: Simon Schrottner <[email protected]>
285a2c9
to
2bf0da4
Compare
currently the build fails for following issues, i will check if this is something fix worthy
|
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@StackScribe @thisthat @thschue @mowies - your input would be highly appreciated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't know what to do with the failing links right now. Status objects are not rendered into the CRD docs, because they are not really needed but the link seem to still be rendered. But I don't link ignore the generated files altogether since we will add other links in there that should be checked. |
I suggest we merge it, with the current configuration and create a follow up to take a look at crd-ref-docs. I think html test adds more benefit, as it would bring us to find a crd-ref solution immediately. WDYT? |
If merging means that all master builds are red then I'm not voting for it 😓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
no worries @mowies, i excluded the lifecyle crd ref for now within the .htmltest.yml file - we can add more any time |
Fixed HTMLTest make target, and added a verification step for GitHub Actions.