Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove kube-rbac-proxy #909

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Feb 24, 2023

Fixes #901

Signed-off-by: Giovanni Liva <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #909 (9ce180c) into main (7b182fa) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
- Coverage   58.60%   58.55%   -0.06%     
==========================================
  Files          97       97              
  Lines        7552     7552              
==========================================
- Hits         4426     4422       -4     
- Misses       2935     2938       +3     
- Partials      191      192       +1     
Impacted Files Coverage Δ
...lers/lifecycle/keptnworkloadinstance/controller.go 81.16% <0.00%> (-1.80%) ⬇️
Flag Coverage Δ
component-tests 42.42% <ø> (+0.22%) ⬆️
keptn-lifecycle-operator 54.67% <ø> (ø)
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@thisthat thisthat marked this pull request as ready for review February 24, 2023 07:59
@thisthat thisthat merged commit 7d2621b into keptn:main Feb 24, 2023
@thisthat thisthat deleted the feat/901/remove-kube-rbac-proxy branch February 24, 2023 08:48
@keptn-bot keptn-bot mentioned this pull request Feb 24, 2023
Amishakumari544 pushed a commit to Amishakumari544/lifecycle-toolkit that referenced this pull request Feb 27, 2023
aepfli pushed a commit to aepfli/lifecycle-toolkit that referenced this pull request Mar 1, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for kube-RBAC-proxy
3 participants