-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include namespace creation in release manifest #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisthat
force-pushed
the
fix/852/add-ns-creation
branch
from
February 15, 2023 10:45
ef35538
to
f2b3356
Compare
Signed-off-by: Giovanni Liva <[email protected]>
thisthat
force-pushed
the
fix/852/add-ns-creation
branch
from
February 15, 2023 10:46
f2b3356
to
454f688
Compare
thisthat
requested review from
thschue,
bacherfl,
mowies and
philipp-hinteregger
as code owners
February 15, 2023 10:46
Kudos, SonarCloud Quality Gate passed! |
thisthat
changed the title
fix(ci): include namespace creation in release manifest
fix: include namespace creation in release manifest
Feb 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
==========================================
- Coverage 58.52% 58.03% -0.50%
==========================================
Files 97 89 -8
Lines 7552 7072 -480
==========================================
- Hits 4420 4104 -316
+ Misses 2939 2820 -119
+ Partials 193 148 -45
Flags with carried forward coverage won't be shown. Click here to find out more. |
bacherfl
approved these changes
Feb 15, 2023
thschue
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merged
RealAnna
pushed a commit
that referenced
this pull request
Feb 22, 2023
RealAnna
pushed a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: realanna <[email protected]>
RealAnna
pushed a commit
that referenced
this pull request
Feb 23, 2023
Signed-off-by: realanna <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #852
Example of run that the ns file is correctly created: https://github.com/thisthat/lifecycle-controller/actions/runs/4183048159/jobs/7246906287