Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include namespace creation in release manifest #855

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Feb 15, 2023

@thisthat thisthat force-pushed the fix/852/add-ns-creation branch from ef35538 to f2b3356 Compare February 15, 2023 10:45
@thisthat thisthat force-pushed the fix/852/add-ns-creation branch from f2b3356 to 454f688 Compare February 15, 2023 10:46
@thisthat thisthat marked this pull request as ready for review February 15, 2023 10:46
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thisthat thisthat changed the title fix(ci): include namespace creation in release manifest fix: include namespace creation in release manifest Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #855 (454f688) into main (0edd9c1) will decrease coverage by 0.50%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #855      +/-   ##
==========================================
- Coverage   58.52%   58.03%   -0.50%     
==========================================
  Files          97       89       -8     
  Lines        7552     7072     -480     
==========================================
- Hits         4420     4104     -316     
+ Misses       2939     2820     -119     
+ Partials      193      148      -45     
Impacted Files Coverage Δ
...anager/controllers/keptnwebhookcontroller/certs.go
klt-cert-manager/kubeutils/query.go
klt-cert-manager/kubeutils/secret.go
klt-cert-manager/eventfilter/eventfilter.go
klt-cert-manager/kubeutils/certificates.go
...okcontroller/keptnwebhookcertificate_controller.go
...rs/keptnwebhookcontroller/webhook_configuration.go
...llers/keptnwebhookcontroller/certificate_secret.go
...lers/lifecycle/keptnworkloadinstance/controller.go 82.51% <0.00%> (+0.89%) ⬆️
...ptnworkloadinstance/reconcile_prepostdeployment.go 90.90% <0.00%> (+9.09%) ⬆️
... and 1 more
Flag Coverage Δ
component-tests 41.79% <ø> (+0.27%) ⬆️
klt-cert-manager ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit d7a2b48 into keptn:main Feb 15, 2023
@keptn-bot keptn-bot mentioned this pull request Feb 15, 2023
RealAnna pushed a commit that referenced this pull request Feb 22, 2023
RealAnna pushed a commit that referenced this pull request Feb 23, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install v0.6.0
3 participants