Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): adapt resource requests and limits #835

Merged
merged 7 commits into from
Feb 14, 2023

Conversation

bacherfl
Copy link
Member

Closes #832
Signed-off-by: Florian Bacher [email protected]

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #835 (59666b5) into main (0edd9c1) will increase coverage by 0.14%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
+ Coverage   58.52%   58.67%   +0.14%     
==========================================
  Files          97       97              
  Lines        7552     7552              
==========================================
+ Hits         4420     4431      +11     
+ Misses       2939     2932       -7     
+ Partials      193      189       -4     
Impacted Files Coverage Δ
...lers/lifecycle/keptnworkloadinstance/controller.go 82.51% <0.00%> (+0.89%) ⬆️
...ator/controllers/lifecycle/keptntask/controller.go 58.24% <0.00%> (+3.29%) ⬆️
...ptnworkloadinstance/reconcile_prepostdeployment.go 90.90% <0.00%> (+9.09%) ⬆️
...ptnworkloadinstance/reconcile_prepostevaluation.go 90.90% <0.00%> (+9.09%) ⬆️
Flag Coverage Δ
component-tests 41.92% <ø> (+0.40%) ⬆️
keptn-lifecycle-operator 54.67% <ø> (ø)
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl marked this pull request as ready for review February 14, 2023 07:55
@bacherfl bacherfl requested a review from thschue as a code owner February 14, 2023 07:55
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't you put the resource settings directly into the manifests instead of using the kustomize patch files?

thisthat
thisthat previously approved these changes Feb 14, 2023
Signed-off-by: Florian Bacher <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl
Copy link
Member Author

why don't you put the resource settings directly into the manifests instead of using the kustomize patch files?

no particular reason; i saw that those were also set in the patch for the rbac-proxy container and did it the same way for the manager - but i agree that it makes more sense to set them in the manifests directly.

@bacherfl bacherfl merged commit 8249de6 into keptn:main Feb 14, 2023
@bacherfl bacherfl deleted the fix/832/memory-limits branch February 14, 2023 09:10
@keptn-bot keptn-bot mentioned this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory limits are wrongly configured
3 participants