-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(operator): adapt resource requests and limits #835
Conversation
Signed-off-by: Florian Bacher <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
+ Coverage 58.52% 58.67% +0.14%
==========================================
Files 97 97
Lines 7552 7552
==========================================
+ Hits 4420 4431 +11
+ Misses 2939 2932 -7
+ Partials 193 189 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't you put the resource settings directly into the manifests instead of using the kustomize patch files?
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
no particular reason; i saw that those were also set in the patch for the rbac-proxy container and did it the same way for the manager - but i agree that it makes more sense to set them in the manifests directly. |
Closes #832
Signed-off-by: Florian Bacher [email protected]