Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add StackScribe as Code Owner of docs #821

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

thisthat
Copy link
Member

@StackScribe has worked hard on our documentation and provided precious suggestions for structuring it and good PR reviews. I think she deserves to be a code owner of our documentation.

@thisthat thisthat force-pushed the add-StackScribe-docs-owner branch from 1dbe31a to 70b548c Compare February 13, 2023 09:12
@thisthat thisthat changed the title chore: Add StackScribe as Code Owner of docs chore: add StackScribe as Code Owner of docs Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #821 (70b548c) into main (5ac17c7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #821   +/-   ##
=======================================
  Coverage   58.56%   58.56%           
=======================================
  Files          97       97           
  Lines        7542     7542           
=======================================
  Hits         4417     4417           
  Misses       2935     2935           
  Partials      190      190           
Flag Coverage Δ
component-tests 42.75% <ø> (+1.04%) ⬆️
keptn-lifecycle-operator 54.67% <ø> (ø)
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mowies mowies merged commit c90db1e into keptn:main Feb 13, 2023
@keptn-bot keptn-bot mentioned this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants