-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add "Intro to KLT"; edit "Getting Started" #785
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
==========================================
+ Coverage 57.38% 57.50% +0.11%
==========================================
Files 119 119
Lines 9914 9913 -1
==========================================
+ Hits 5689 5700 +11
+ Misses 4027 4015 -12
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. |
looks good. One more thing. Henrik Rexed is currently working on an IsItObservable YouTube Tutorial for KLT. I think that would be a great asset as well on "How to get started". Here is the github repo that goes along with his youtube tutorial -> https://github.com/isItObservable/keptn-lifecycle-Toolkit. the tutorial itself should go live any day now |
Thanks, @grabnerandi ! I just added a link to the docs for this. I'll add a link to the video as soon as it is posted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Meg McRoberts <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]> Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
BREAKING-CHANGE: The handling of the CRD lifecycle and metrics has been split into two different operators feat(operator): adapt KeptnEvaluationDefinition to reflect changes in KeptnMetric and KeptnMetricsProvider feat: use helmify to release our helm chart feat(metrics-operator): added conversion webhook for KeptnMetric CRDs feat(cert-manager): support certificate injection for all matching resources based on label selector feat: introduce lifecycle.keptn.sh/v1alpha3 API version feat(metrics-operator): allow KeptnMetrics to be placed in any namespace feat: adapt examples to use KeptnMetric and KeptnMetricsProvider chore(operator): remove KeptnMetric and KeptnEvaluationProvider from klt operator fix(metrics-operator): adapt metric types from v1alpha1 fix(operator): invalid import of metrics feat(metrics-operator): implement metric functionality ci(metrics-operator): adapt pipelines feat(metrics-operator): introduce migration from KeptnEvaluationProvider to KeptnMetricsProvider feat(metrics-operator): introduce KeptnMetricsProvider CRD feat: added the metrics-operator Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Signed-off-by: Meg McRoberts [email protected] Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Meg McRoberts [email protected]
This PR: