Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: set up directory for Architecture docs #773

Merged
merged 3 commits into from
Feb 8, 2023
Merged

docs: set up directory for Architecture docs #773

merged 3 commits into from
Feb 8, 2023

Conversation

StackScribe
Copy link
Contributor

Signed-off-by: Meg McRoberts [email protected]

This just sets up the directory so has no interesting content.

#770

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #773 (5c05ef6) into main (ce6b7f0) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   57.75%   57.69%   -0.06%     
==========================================
  Files          91       91              
  Lines        7243     7243              
==========================================
- Hits         4183     4179       -4     
- Misses       2891     2894       +3     
- Partials      169      170       +1     
Impacted Files Coverage Δ
...lers/lifecycle/keptnworkloadinstance/controller.go 80.99% <0.00%> (-1.81%) ⬇️
Flag Coverage Δ
component-tests 47.77% <ø> (-0.79%) ⬇️
keptn-lifecycle-operator 53.60% <ø> (ø)
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@thschue
Copy link
Contributor

thschue commented Feb 6, 2023

Thank you for this PR. I don't know if an additional architecture section wouldn't lead to confusion, as there is already a concepts section and, as far as I know, a reference planned.

@thisthat, @bacherfl, @checkelmann: What do you think about it?

@thschue thschue changed the title Set up directory for Architecture docs docs: set up directory for Architecture docs Feb 6, 2023
@thisthat thisthat changed the title docs: set up directory for Architecture docs doc: set up directory for Architecture docs Feb 6, 2023
@thisthat thisthat changed the title doc: set up directory for Architecture docs docs: set up directory for Architecture docs Feb 6, 2023
@thisthat
Copy link
Member

thisthat commented Feb 6, 2023

With the introduction of the Metric Server, a dedicated section for the architecture makes sense to me. Here, we can also go into more detail about how our CRDs work. In particular, why we have Workload and WorkloadInstance.

@thschue
Copy link
Contributor

thschue commented Feb 6, 2023

As discussed with @thisthat, the initial idea was to have this kind of information in the "concepts" section together with a reference section, this should be enough architectural things in the docs ...

Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
Copy link
Contributor Author

The "Concepts" section should explain things at a bit higher level than Architecture. The Architecture section gets into more details. For example, see #689 . I did create an epic where we can discuss this. For now, I'd like to start this section and populate it and see where it goes. Files can be moved around later if appropriate.

@StackScribe StackScribe requested a review from RealAnna February 6, 2023 14:25
@agardnerIT
Copy link
Contributor

Can / should we provide diagrams as code with libraries such as D2 or mingrammer/diagrams

@StackScribe
Copy link
Contributor Author

@agardnerIT Graphics would probably be nice. I'm not a real visual person but lots of our users are. Let me start drafting this doc and then I'll get details from you about how to implement some graphics and we'll go from there.

@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@StackScribe
Copy link
Contributor Author

We need a separate discussion about the general structure of the documentation set; this discussion should not be derailing this PR. So to unblock myself, I have moved the Architecture section under "Concepts" so that I can work on content while we have the larger discussions.

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 7c3696e into keptn:main Feb 8, 2023
@keptn-bot keptn-bot mentioned this pull request Feb 8, 2023
@StackScribe StackScribe deleted the 0205-arch-setup branch February 11, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants