Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): refactored metric adapter for helm generation #725

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

RealAnna
Copy link
Contributor

Signed-off-by: realanna [email protected]

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #725 (9fb3bbb) into main (8cfb221) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
+ Coverage   57.35%   57.44%   +0.09%     
==========================================
  Files          89       89              
  Lines        7011     7012       +1     
==========================================
+ Hits         4021     4028       +7     
+ Misses       2823     2819       -4     
+ Partials      167      165       -2     
Impacted Files Coverage Δ
operator/cmd/metrics/adapter/provider/provider.go 81.81% <100.00%> (+0.16%) ⬆️
...lers/lifecycle/keptnworkloadinstance/controller.go 82.80% <0.00%> (+1.35%) ⬆️
...ptnworkloadinstance/reconcile_prepostevaluation.go 90.90% <0.00%> (+9.09%) ⬆️
Flag Coverage Δ
component-tests 53.95% <ø> (+0.69%) ⬆️
keptn-lifecycle-operator 53.10% <100.00%> (+<0.01%) ⬆️
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: realanna <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit e271162 into main Jan 31, 2023
@RealAnna RealAnna deleted the fix/helm_overley_for_metrics_adapter branch January 31, 2023 09:35
@keptn-bot keptn-bot mentioned this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants