Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cert-manager to missing pipelines + fix linter issues #702

Merged
merged 3 commits into from
Jan 27, 2023
Merged

fix: add cert-manager to missing pipelines + fix linter issues #702

merged 3 commits into from
Jan 27, 2023

Conversation

odubajDT
Copy link
Contributor

Signed-off-by: odubajDT [email protected]

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #702 (3d5331b) into main (eab9397) will decrease coverage by 0.08%.
The diff coverage is 49.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   56.63%   56.55%   -0.08%     
==========================================
  Files          83       83              
  Lines        6754     6760       +6     
==========================================
- Hits         3825     3823       -2     
- Misses       2770     2775       +5     
- Partials      159      162       +3     
Impacted Files Coverage Δ
...okcontroller/keptnwebhookcertificate_controller.go 52.00% <31.81%> (-1.85%) ⬇️
...llers/keptnwebhookcontroller/certificate_secret.go 85.88% <100.00%> (ø)
klt-cert-manager/kubeutils/query.go 100.00% <100.00%> (ø)
klt-cert-manager/kubeutils/secret.go 67.39% <100.00%> (ø)
...ptnworkloadinstance/reconcile_prepostdeployment.go 81.81% <0.00%> (-9.10%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 78.24% <0.00%> (+0.46%) ⬆️
Flag Coverage Δ
component-tests 53.54% <ø> (+0.52%) ⬆️
keptn-cert-manager 67.50% <49.15%> (-0.86%) ⬇️
keptn-lifecycle-operator 52.09% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT changed the title fix: add cert-manager to release pipeline fix: add cert-manager to missing pipelines Jan 26, 2023
@odubajDT odubajDT marked this pull request as ready for review January 26, 2023 14:03
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT changed the title fix: add cert-manager to missing pipelines fix: add cert-manager to missing pipelines + fix linter issues Jan 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit a4ab1e3 into keptn:main Jan 27, 2023
@keptn-bot keptn-bot mentioned this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants