Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operator): added adapter for custom metrics #682

Merged
merged 44 commits into from
Jan 27, 2023
Merged

feat(operator): added adapter for custom metrics #682

merged 44 commits into from
Jan 27, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Jan 23, 2023 •
edited
Loading

Closes #601
This PR makes the recently introduced KeptnMetrics available as custom metrics in the K8s API

Note: Will add the docs about this feature in a separate PR after #684 is merged

@codecov
Copy link

codecov bot commented Jan 23, 2023 •
edited
Loading

Codecov Report

Merging #682 (188722b) into main (eab9397) will increase coverage by 0.57%.
The diff coverage is 88.09%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
+ Coverage   56.63%   57.21%   +0.57%     
==========================================
  Files          83       88       +5     
  Lines        6754     6990     +236     
==========================================
+ Hits         3825     3999     +174     
- Misses       2770     2826      +56     
- Partials      159      165       +6
Impacted Files Coverage Δ
operator/cmd/metrics/adapter/provider/provider.go 81.65% <81.65%> (ø)
...tor/cmd/metrics/adapter/provider/custom_metrics.go 100.00% <100.00%> (ø)
...ptnworkloadinstance/reconcile_prepostdeployment.go 81.81% <0.00%> (-9.10%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 76.38% <0.00%> (-1.39%) ⬇️
operator/cmd/config/config.go 40.00% <0.00%> (ø)
operator/cmd/webhook/manager.go 100.00% <0.00%> (ø)
operator/cmd/webhook/builder.go 25.00% <0.00%> (ø)
Flag Coverage Δ
component-tests 52.84% <ø> (-0.18%) ⬇️
keptn-cert-manager 68.35% <ø> (ø)
keptn-lifecycle-operator 53.00% <88.09%> (+0.90%) ⬆️
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl force-pushed the feat/bootstrap-metrics-adapter branch 3 times, most recently from 3131620 to 1367be8 Compare January 25, 2023 10:00
@bacherfl bacherfl marked this pull request as ready for review January 25, 2023 10:11
@bacherfl bacherfl changed the title feat: added adapter for custom metrics feat(operator): added adapter for custom metrics Jan 25, 2023
odubajDT
odubajDT previously approved these changes Jan 26, 2023
View reviewed changes
bacherfl added 17 commits January 26, 2023 12:55
@bacherfl
fix unit test path
6ba6010 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
debug test
e91827c 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
remove unneeded code
98944fd 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fixed unit tests
48bef5b 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
adapt coverage generation
0ae68a8 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
add integration test
8c3814d 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fixed unit test
aa7e57b 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fixed typo
cf73506 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
adapted to changes in kuttl test
4a2dcd3 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fix linting
ce515d8 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
remove obsolete parts of metrics retrieval script
26d373f 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
clean up, added comments
a110e78 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
remove kubectl proxy command
c9095ec 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
pr review
5d8b232 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
added newline
43e7cdc 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
pr review
9db748b 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fixed merge conflicts
93b126c 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl force-pushed the feat/bootstrap-metrics-adapter branch from d275aba to 93b126c Compare January 26, 2023 11:56
odubajDT
odubajDT previously approved these changes Jan 26, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit 64cb972 into keptn:main Jan 27, 2023
@bacherfl bacherfl deleted the feat/bootstrap-metrics-adapter branch January 27, 2023 09:13
@keptn-bot keptn-bot mentioned this pull request Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@thisthat thisthat thisthat approved these changes

@thschue thschue Awaiting requested review from thschue

@RealAnna RealAnna Awaiting requested review from RealAnna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrap Metric Adapter
3 participants
@bacherfl @thisthat @odubajDT