-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add keptn certificate manager infos #652
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
==========================================
- Coverage 57.33% 57.24% -0.09%
==========================================
Files 88 88
Lines 7001 7001
==========================================
- Hits 4014 4008 -6
- Misses 2821 2825 +4
- Partials 166 168 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
dc0ad99
to
c0cebf5
Compare
docs/content/en/docs/concepts/overview/klc-cert-manager/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/overview/klc-cert-manager/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/overview/klc-cert-manager/_index.md
Outdated
Show resolved
Hide resolved
24308a2
to
f21b84f
Compare
docs/content/en/docs/concepts/overview/klc-cert-manager/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/overview/klc-cert-manager/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/overview/klc-cert-manager/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/overview/klc-cert-manager/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/overview/klc-cert-manager/_index.md
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! I made a few word-smithing suggestions for your consideration. Nothing that is required.
docs/content/en/docs/concepts/overview/klc-cert-manager/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/overview/klc-cert-manager/_index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: RealAnna <[email protected]>
Signed-off-by: realanna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: RealAnna <[email protected]>
Signed-off-by: realanna <[email protected]>
ee7b95b
to
e32eee8
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fixes #657
with this pr we should also signal the breakingchange so plz do not merge without
BREAKING CHANGE: The dependency on cert-manager has been removed in favor of a custom implementation. With these changes, the operator will be waiting for a certificate to be ready before registering the controllers. The certificate is generated as a k8s secret in the lifecycle-toolkit namespace and then loaded into an empty dir volume. The Keptn certificate manager will make sure to renew it (every 12 hours) and will take care of its validity every time the controller manager deployment resource changes.