Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add keptn certificate manager infos #652

Merged
merged 35 commits into from
Jan 31, 2023
Merged

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Jan 18, 2023

Fixes #657
with this pr we should also signal the breakingchange so plz do not merge without

BREAKING CHANGE: The dependency on cert-manager has been removed in favor of a custom implementation. With these changes, the operator will be waiting for a certificate to be ready before registering the controllers. The certificate is generated as a k8s secret in the lifecycle-toolkit namespace and then loaded into an empty dir volume. The Keptn certificate manager will make sure to renew it (every 12 hours) and will take care of its validity every time the controller manager deployment resource changes.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #652 (a8e80f5) into main (d33af19) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head a8e80f5 differs from pull request most recent head e32eee8. Consider uploading reports for the commit e32eee8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
- Coverage   57.33%   57.24%   -0.09%     
==========================================
  Files          88       88              
  Lines        7001     7001              
==========================================
- Hits         4014     4008       -6     
- Misses       2821     2825       +4     
- Partials      166      168       +2     
Impacted Files Coverage Δ
...ptnworkloadinstance/reconcile_prepostevaluation.go 81.81% <0.00%> (-9.10%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 80.09% <0.00%> (-1.36%) ⬇️
Flag Coverage Δ
keptn-cert-manager ?
keptn-lifecycle-operator 53.05% <ø> (ø)
klt-cert-manager 67.50% <ø> (?)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna marked this pull request as ready for review January 19, 2023 12:32
@RealAnna RealAnna force-pushed the doc/add_info_on_certificates branch from dc0ad99 to c0cebf5 Compare January 19, 2023 13:57
README.md Outdated Show resolved Hide resolved
docs/content/en/docs/snippets/tasks/install.md Outdated Show resolved Hide resolved
docs/content/en/docs/snippets/tasks/install.md Outdated Show resolved Hide resolved
docs/content/en/docs/snippets/tasks/install.md Outdated Show resolved Hide resolved
klt-cert-manager/README.md Outdated Show resolved Hide resolved
@RealAnna RealAnna requested a review from StackScribe January 23, 2023 10:18
@RealAnna RealAnna force-pushed the doc/add_info_on_certificates branch from 24308a2 to f21b84f Compare January 26, 2023 07:56
README.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

StackScribe
StackScribe previously approved these changes Jan 26, 2023
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! I made a few word-smithing suggestions for your consideration. Nothing that is required.

thisthat
thisthat previously approved these changes Jan 27, 2023
@RealAnna RealAnna requested a review from StackScribe January 27, 2023 09:04
docs/content/en/docs/snippets/tasks/install.md Outdated Show resolved Hide resolved
docs/content/en/docs/snippets/tasks/install.md Outdated Show resolved Hide resolved
examples/support/argo/Makefile Outdated Show resolved Hide resolved
klt-cert-manager/Makefile Outdated Show resolved Hide resolved
klt-cert-manager/README.md Outdated Show resolved Hide resolved
klt-cert-manager/README.md Outdated Show resolved Hide resolved
RealAnna and others added 22 commits January 30, 2023 17:39
Signed-off-by: realanna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: realanna <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 8cfb221 into main Jan 31, 2023
@RealAnna RealAnna deleted the doc/add_info_on_certificates branch January 31, 2023 08:00
@keptn-bot keptn-bot mentioned this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keptn Cert-Manager :: Update documentation
5 participants