Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fail linter CI jobs when checks are failing #630

Merged
merged 1 commit into from
Jan 16, 2023
Merged

chore: fail linter CI jobs when checks are failing #630

merged 1 commit into from
Jan 16, 2023

Conversation

odubajDT
Copy link
Contributor

Signed-off-by: odubajDT [email protected]

@sonarcloud
Copy link

sonarcloud bot commented Jan 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #630 (454cf3a) into main (278c74b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #630   +/-   ##
=======================================
  Coverage   54.26%   54.26%           
=======================================
  Files          77       77           
  Lines        6446     6446           
=======================================
  Hits         3498     3498           
  Misses       2798     2798           
  Partials      150      150           
Flag Coverage Δ
keptn-cert-manager 67.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT merged commit a5e0eaa into keptn:main Jan 16, 2023
@keptn-bot keptn-bot mentioned this pull request Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants