Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: annotate K8s Events #589

Merged
merged 14 commits into from
Jan 17, 2023
Merged

feat: annotate K8s Events #589

merged 14 commits into from
Jan 17, 2023

Conversation

odubajDT
Copy link
Contributor

Signed-off-by: odubajDT [email protected]

Fixes: #586

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #589 (4b3dbf0) into main (88e7ac4) will increase coverage by 1.55%.
The diff coverage is 77.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   53.27%   54.82%   +1.55%     
==========================================
  Files          69       78       +9     
  Lines        6003     6515     +512     
==========================================
+ Hits         3198     3572     +374     
- Misses       2693     2794     +101     
- Partials      112      149      +37     
Impacted Files Coverage Δ
operator/apis/lifecycle/v1alpha2/common/phases.go 100.00% <ø> (ø)
operator/controllers/common/evaluationhandler.go 79.71% <ø> (ø)
operator/controllers/common/phasehandler.go 81.25% <ø> (-0.57%) ⬇️
...ontrollers/lifecycle/keptnevaluation/controller.go 0.00% <0.00%> (ø)
operator/webhooks/pod_mutating_webhook.go 35.83% <0.00%> (ø)
...rator/controllers/lifecycle/keptntask/job_utils.go 38.31% <14.28%> (ø)
...or/controllers/lifecycle/interfaces/eventobject.go 62.50% <62.50%> (ø)
...rator/controllers/lifecycle/keptnapp/controller.go 68.42% <75.00%> (ø)
operator/apis/lifecycle/v1alpha2/keptnapp_types.go 93.33% <100.00%> (+1.66%) ⬆️
...r/apis/lifecycle/v1alpha2/keptnappversion_types.go 97.59% <100.00%> (+0.07%) ⬆️
... and 16 more
Flag Coverage Δ
component-tests 54.25% <68.75%> (+2.02%) ⬆️
keptn-cert-manager 67.72% <ø> (?)
keptn-lifecycle-operator 52.13% <77.06%> (+0.53%) ⬆️
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

odubajDT and others added 6 commits January 12, 2023 08:25
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@mowies mowies changed the title chore: refactored k8s Events recording chore: refactor k8s Events recording Jan 12, 2023
@odubajDT odubajDT changed the title chore: refactor k8s Events recording feat: annotate k8s Events Jan 12, 2023
@odubajDT odubajDT changed the title feat: annotate k8s Events feat: annotate K8s Events Jan 12, 2023
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT marked this pull request as ready for review January 12, 2023 13:34
@odubajDT odubajDT marked this pull request as draft January 12, 2023 13:48
@odubajDT odubajDT marked this pull request as ready for review January 12, 2023 14:29
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT requested a review from thisthat January 16, 2023 07:26
Signed-off-by: odubajDT <[email protected]>
RealAnna
RealAnna previously approved these changes Jan 16, 2023
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit 4ea7da9 into keptn:main Jan 17, 2023
@keptn-bot keptn-bot mentioned this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotate K8s events
3 participants