Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operator): Added metrics #55

Merged
merged 22 commits into from
Oct 6, 2022
Merged

feat(operator): Added metrics #55

merged 22 commits into from
Oct 6, 2022

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Sep 29, 2022 •
edited by odubajDT
Loading

Closes #44 #88

image

@RealAnna RealAnna mentioned this pull request Sep 29, 2022
Closed
@thisthat thisthat marked this pull request as ready for review September 30, 2022 06:48
@thisthat thisthat marked this pull request as draft September 30, 2022 06:48
@odubajDT odubajDT force-pushed the feat/metrics branch 2 times, most recently from ee6b765 to d504353 Compare October 3, 2022 10:25
@thschue thschue changed the title feat: Added metrics feat(operator): Added metrics Oct 3, 2022
@odubajDT
Copy link
Contributor

odubajDT commented Oct 4, 2022

to display metrics run:

kubectl port-forward -n <namespace> <operator-pod> 2222:2222

@odubajDT odubajDT force-pushed the feat/metrics branch 3 times, most recently from 4d04572 to 210ec2d Compare October 5, 2022 09:42
@odubajDT odubajDT marked this pull request as ready for review October 5, 2022 13:45
thisthat
thisthat reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Great work! :shipit:
I left only minor suggestions

examples/single-service/pre-deployment-tasks.yaml Outdated Show resolved Hide resolved
operator/api/v1alpha1/keptntask_types.go Outdated Show resolved Hide resolved
operator/api/v1alpha1/keptntask_types.go Outdated Show resolved Hide resolved
operator/api/v1alpha1/keptntask_types.go Outdated Show resolved Hide resolved
operator/api/v1alpha1/keptntask_types.go Outdated Show resolved Hide resolved
@bacherfl bacherfl mentioned this pull request Oct 6, 2022
Closed
thisthat and others added 8 commits October 6, 2022 08:32
@thisthat @odubajDT
Export task counter
a9d7286 
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: RealAnna <[email protected]>
@thisthat @odubajDT
fix typo
2bfb390 
Signed-off-by: Giovanni Liva <[email protected]>
@thisthat @odubajDT
Change k8s version
18a37cb 
Signed-off-by: Giovanni Liva <[email protected]>
@thisthat @odubajDT
Add DT annotation to scrape Prometheus metrics
fd74b24 
Signed-off-by: Giovanni Liva <[email protected]>
@thisthat @odubajDT
Revert Makefile
10e7b4d 
Signed-off-by: Giovanni Liva <[email protected]>
@RealAnna @odubajDT
chore: added helpers in make for development
c1dea09 
Signed-off-by: RealAnna <[email protected]>
@RealAnna @odubajDT
feat: Add metrics
01598c5 
Signed-off-by: RealAnna <[email protected]>
@RealAnna @odubajDT
feat: added new studd
f8c6979 
Signed-off-by: RealAnna <[email protected]>
odubajDT added 11 commits October 6, 2022 08:34
@odubajDT
task and deployment counter
3b1cb7f 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
create histograms for durations
881b50a 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
duration and count of deployments working
02fef8c 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
add tasktime to workloadInstance TaskStatuses
b3dbd85 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
working version of deployment counter and duration metrics
a10053e 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
added metrics for task count and duration
cf9d8e3 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
minor fix for task durations
4c02af9 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
working version
e0eec12 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
pr review
ccfe706 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
pr review
2709c0e 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
pr review
9f5f602 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fix minor issue
257bfc2 
Signed-off-by: odubajDT <[email protected]>
thisthat
thisthat reviewed Oct 6, 2022
View reviewed changes
operator/api/v1alpha1/common/common.go Outdated Show resolved Hide resolved
operator/api/v1alpha1/common/common.go Outdated Show resolved Hide resolved
operator/api/v1alpha1/common/common.go Outdated Show resolved Hide resolved
operator/api/v1alpha1/common/common.go Outdated Show resolved Hide resolved
operator/api/v1alpha1/common/common.go Outdated Show resolved Hide resolved
operator/api/v1alpha1/common/common.go Outdated Show resolved Hide resolved
operator/api/v1alpha1/common/common.go Outdated Show resolved Hide resolved
operator/controllers/semconv/keptn.go Outdated Show resolved Hide resolved
@odubajDT
final pr review
68180a1 
Signed-off-by: odubajDT <[email protected]>
thisthat
thisthat reviewed Oct 6, 2022
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a minor comment

operator/api/v1alpha1/common/common.go Outdated Show resolved Hide resolved
@odubajDT
renaming
d4105ea 
Signed-off-by: odubajDT <[email protected]>
thisthat
thisthat approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@odubajDT odubajDT merged commit f8a3cee into main Oct 6, 2022
@odubajDT odubajDT deleted the feat/metrics branch October 6, 2022 11:10
@github-actions github-actions bot mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT left review comments

@bacherfl bacherfl bacherfl approved these changes

@thisthat thisthat thisthat approved these changes

@thschue thschue Awaiting requested review from thschue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metric capabilities
4 participants
@RealAnna @odubajDT @thisthat @bacherfl