Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce API groups in KLT #547

Merged
merged 17 commits into from
Jan 9, 2023
Merged

feat: introduce API groups in KLT #547

merged 17 commits into from
Jan 9, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Dec 19, 2022 •
edited
Loading

This PR

  • introduces API groups in the KLT
  • this will have some advantages in the future when we want to add other CRDs that are not related to lifecycle management

Part of #545

@codecov
Copy link

codecov bot commented Dec 19, 2022 •
edited
Loading

Codecov Report

Merging #547 (90bbdba) into main (90bbdba) will not change coverage.
The diff coverage is n/a.

❗ Current head 90bbdba differs from pull request most recent head 4c6071c. Consider uploading reports for the commit 4c6071c to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #547   +/-   ##
=======================================
  Coverage   49.94%   49.94%           
=======================================
  Files          60       60           
  Lines        5528     5528           
=======================================
  Hits         2761     2761           
  Misses       2660     2660           
  Partials      107      107
Flag Coverage Δ
component-tests 50.43% <0.00%> (ø)
keptn-lifecycle-operator 47.85% <0.00%> (ø)
scheduler 21.17% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies force-pushed the options-crd-poc branch 3 times, most recently from 7abbd45 to e164a58 Compare December 21, 2022 07:17
@mowies mowies changed the title feat: configure KLT through CRDs (PoC) feat: introduce API groups in KLT Dec 29, 2022
@mowies mowies marked this pull request as ready for review December 29, 2022 09:37
@mowies mowies mentioned this pull request Dec 29, 2022
Closed
thschue
thschue previously approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

RealAnna
RealAnna previously approved these changes Jan 9, 2023
View reviewed changes
bacherfl
bacherfl previously approved these changes Jan 9, 2023
View reviewed changes
mowies added 13 commits January 9, 2023 15:20
@mowies
change to multi-group API
406093e 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
add new options API and set it up to configure the operator
dee0458 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
add defaults for config settings
1ff14b9 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fixed wrongly moved files
c4f58d2 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix makefile
4767a14 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix formatting
b255ace 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix default value
13b6360 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
revert functions runner image
e1b1653 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
revert api changes, move common out of controllers
e881a60 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix go mod
900ce5b 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix go mod
240b4a4 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
revert controller config
d3ac340 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
readd otel collector url
bdb4f79 
Signed-off-by: Moritz Wiesinger <[email protected]>
mowies added 4 commits January 9, 2023 15:20
@mowies
remove unneeded options files
edfb7ab 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
disable controller config
4a045b5 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix rebase artifacts
11d5db9 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix rebase artifacts
4c6071c 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies dismissed stale reviews from bacherfl and RealAnna via 4c6071c January 9, 2023 14:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies merged commit b482d96 into keptn:main Jan 9, 2023
@keptn-bot keptn-bot mentioned this pull request Jan 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna approved these changes

@bacherfl bacherfl bacherfl approved these changes

@thschue thschue thschue left review comments

@thisthat thisthat Awaiting requested review from thisthat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mowies @bacherfl @thschue @RealAnna