feat(operator): add version conversion rule for KeptnEvaluationProvider

[thisthat]

Signed-off-by: Giovanni Liva [email protected]

[codecov]

Codecov Report

Merging #531 (b33247f) into main (b482d96) will increase coverage by 0.11%.
The diff coverage is 83.78%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
+ Coverage   49.94%   50.06%   +0.11%     
==========================================
  Files          60       63       +3     
  Lines        5528     5565      +37     
==========================================
+ Hits         2761     2786      +25     
- Misses       2660     2670      +10     
- Partials      107      109       +2     

Impacted Files	Coverage Δ
operator/apis/lifecycle/v1alpha1/common/common.go	100.00% <ø> (ø)
...cle/v1alpha2/keptnevaluationprovider_conversion.go	0.00% <0.00%> (ø)
...ecycle/v1alpha2/keptnevaluationprovider_webhook.go	0.00% <0.00%> (ø)
...cle/v1alpha1/keptnevaluationprovider_conversion.go	100.00% <100.00%> (ø)
...ptnworkloadinstance/reconcile_prepostevaluation.go	81.81% <0.00%> (-9.10%)	⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go	77.55% <0.00%> (-1.54%)	⬇️

Flag	Coverage Δ
component-tests	49.96% <ø> (-0.24%)	⬇️
keptn-lifecycle-operator	48.10% <83.78%> (+0.24%)	⬆️
scheduler	21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[mowies]

To enable the conversion webhooks, you need to enable them in the kubebuilder PROJECT file and also enable the corresponding kustomizations. You can check the changes I made to those file in my PR

kubebuilder actually does that for you if you use the CLI to create the conversion webhook files :)

[odubajDT]

I think you also need to enable kustomizations, like here

https://github.com/keptn/lifecycle-toolkit/pull/569/files#diff-b4264f54ad8ffa078bdc5cf96dba3ba7af6f506d6f5b74ec49561352b86c6acaR36

or here

https://github.com/keptn/lifecycle-toolkit/pull/494/files#diff-b4264f54ad8ffa078bdc5cf96dba3ba7af6f506d6f5b74ec49561352b86c6acaR34

[mowies]

like @odubajDT said, you still need to enable the webhook in the kustomization.yaml file. please check his comment on how to do it

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[mowies]

sorry to have more comments, but an integration test for the conversion would be great to verify if the thing works correctly

[thisthat]

sorry to have more comments, but an integration test for the conversion would be great to verify if the thing works correctly

I will take this as follow-up of this PR and introduce multiple tests to also verify all the conversion webhooks we have. For that, I've created #576

[bacherfl]

lgtm - I will add an integration test for the evaluationProvider conversions in a follow up PR

[mowies]

LGTM!