Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a new operator for self-hosted certificate management #523

Merged
merged 9 commits into from
Jan 9, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Dec 15, 2022

This PR:

  1. adds a new operator with a single controller
  2. the controller will be watching deployments of the lifecycle toolkit
  3. the controller will check webhooks configuraitons, to create needed certificates

NOTES: the actual implementation logic of the secrets will be in an other pr, this is also why there are not many tests here, most of the code of this pr is autogenerated with kubebuilder :)

cert-manager/Makefile Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #523 (2ac3bf7) into main (deb1027) will increase coverage by 1.44%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   48.50%   49.94%   +1.44%     
==========================================
  Files          60       60              
  Lines        5443     5528      +85     
==========================================
+ Hits         2640     2761     +121     
+ Misses       2692     2660      -32     
+ Partials      111      107       -4     
Impacted Files Coverage Δ
operator/controllers/keptnapp/controller.go 68.42% <0.00%> (-9.23%) ⬇️
operator/webhooks/pod_mutating_webhook.go 35.83% <0.00%> (-0.11%) ⬇️
operator/api/v1alpha2/keptnapp_types.go 91.66% <0.00%> (ø)
...ator/api/v1alpha2/keptnevaluationprovider_types.go 100.00% <0.00%> (ø)
operator/api/v1alpha2/keptnappversion_types.go 97.52% <0.00%> (+0.41%) ⬆️
...erator/api/v1alpha2/keptnworkloadinstance_types.go 91.62% <0.00%> (+0.85%) ⬆️
...or/controllers/keptnworkloadinstance/controller.go 79.08% <0.00%> (+1.76%) ⬆️
...ptnworkloadinstance/reconcile_prepostevaluation.go 90.90% <0.00%> (+9.09%) ⬆️
...keptnworkloadinstance/reconcile_deploymentstate.go 85.24% <0.00%> (+22.95%) ⬆️
scheduler/pkg/klcpermit/workflow_manager.go 52.22% <0.00%> (+40.98%) ⬆️
Flag Coverage Δ
component-tests 50.43% <ø> (-0.46%) ⬇️
keptn-lifecycle-operator 47.85% <ø> (+0.78%) ⬆️
scheduler 21.17% <ø> (+16.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna force-pushed the feat/introduce_certmanager_operator branch from 5056cfc to c7a0e9c Compare December 15, 2022 11:45
cert-manager/Makefile Outdated Show resolved Hide resolved
@mowies mowies changed the title feat: added a new operator for a self-hosted cert-manager feat: add a new operator for self-hosted certificate management Dec 15, 2022
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the kubebuilder PROJECT file missing here?

cert-manager/Dockerfile Outdated Show resolved Hide resolved
cert-manager/Dockerfile Outdated Show resolved Hide resolved
cert-manager/Dockerfile Outdated Show resolved Hide resolved
cert-manager/Dockerfile Outdated Show resolved Hide resolved
cert-manager/Dockerfile Outdated Show resolved Hide resolved
cert-manager/config/manager/manager.yaml Outdated Show resolved Hide resolved
cert-manager/config/manager/kustomization.yaml Outdated Show resolved Hide resolved
cert-manager/config/default/manager_auth_proxy_patch.yaml Outdated Show resolved Hide resolved
cert-manager/main.go Outdated Show resolved Hide resolved
Signed-off-by: RealAnna <[email protected]>

feat: added base for cert-manager

Signed-off-by: RealAnna <[email protected]>
@RealAnna RealAnna force-pushed the feat/introduce_certmanager_operator branch from c7a0e9c to 2dae13f Compare December 15, 2022 13:57
cert-manager/go.mod Outdated Show resolved Hide resolved
odubajDT
odubajDT previously approved these changes Dec 16, 2022
klc-cert-manager/Makefile Outdated Show resolved Hide resolved
klc-cert-manager/Makefile Outdated Show resolved Hide resolved
klc-cert-manager/PROJECT Outdated Show resolved Hide resolved
klc-cert-manager/PROJECT Outdated Show resolved Hide resolved
klc-cert-manager/PROJECT Outdated Show resolved Hide resolved
klc-cert-manager/PROJECT Outdated Show resolved Hide resolved
klc-cert-manager/PROJECT Outdated Show resolved Hide resolved
klc-cert-manager/config/default/kustomization.yaml Outdated Show resolved Hide resolved
klc-cert-manager/config/manager/manager.yaml Outdated Show resolved Hide resolved
Signed-off-by: RealAnna <[email protected]>

rename

Signed-off-by: RealAnna <[email protected]>

rename

Signed-off-by: RealAnna <[email protected]>

feat: peer review

Signed-off-by: RealAnna <[email protected]>
@RealAnna RealAnna force-pushed the feat/introduce_certmanager_operator branch from 736688e to 20fb545 Compare December 20, 2022 10:13
klt-cert-manager/go.mod Outdated Show resolved Hide resolved
RealAnna and others added 4 commits December 21, 2022 11:09
Co-authored-by: odubajDT <[email protected]>
Signed-off-by: RealAnna <[email protected]>
…okcertificate_controller.go

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: odubajDT <[email protected]>
Signed-off-by: RealAnna <[email protected]>
odubajDT
odubajDT previously approved these changes Dec 21, 2022
@RealAnna RealAnna requested a review from mowies December 21, 2022 12:33
klt-cert-manager/Dockerfile Outdated Show resolved Hide resolved
klt-cert-manager/Makefile Outdated Show resolved Hide resolved
klt-cert-manager/Dockerfile Show resolved Hide resolved
klt-cert-manager/Dockerfile Outdated Show resolved Hide resolved
klt-cert-manager/Makefile Outdated Show resolved Hide resolved
klt-cert-manager/config/manager/kustomization.yaml Outdated Show resolved Hide resolved
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RealAnna RealAnna merged commit 90bbdba into main Jan 9, 2023
@RealAnna RealAnna deleted the feat/introduce_certmanager_operator branch January 9, 2023 14:12
@keptn-bot keptn-bot mentioned this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants