-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new operator for self-hosted certificate management #523
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
==========================================
+ Coverage 48.50% 49.94% +1.44%
==========================================
Files 60 60
Lines 5443 5528 +85
==========================================
+ Hits 2640 2761 +121
+ Misses 2692 2660 -32
+ Partials 111 107 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
5056cfc
to
c7a0e9c
Compare
cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the kubebuilder PROJECT
file missing here?
cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: RealAnna <[email protected]> feat: added base for cert-manager Signed-off-by: RealAnna <[email protected]>
c7a0e9c
to
2dae13f
Compare
cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
klc-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
klc-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
klc-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: RealAnna <[email protected]> rename Signed-off-by: RealAnna <[email protected]> rename Signed-off-by: RealAnna <[email protected]> feat: peer review Signed-off-by: RealAnna <[email protected]>
736688e
to
20fb545
Compare
klt-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
Co-authored-by: odubajDT <[email protected]> Signed-off-by: RealAnna <[email protected]>
…okcertificate_controller.go Co-authored-by: odubajDT <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: odubajDT <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: odubajDT <[email protected]> Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR:
NOTES: the actual implementation logic of the secrets will be in an other pr, this is also why there are not many tests here, most of the code of this pr is autogenerated with kubebuilder :)