Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboards): use fixed color mode for succeeded AppVersion/WorkloadInstance tiles #515

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

bacherfl
Copy link
Member

Closes #496

Signed-off-by: Florian Bacher [email protected]

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #515 (d3e809e) into main (58a91ed) will decrease coverage by 0.28%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   48.90%   48.61%   -0.29%     
==========================================
  Files          55       60       +5     
  Lines        5143     5443     +300     
==========================================
+ Hits         2515     2646     +131     
- Misses       2523     2688     +165     
- Partials      105      109       +4     
Impacted Files Coverage Δ
operator/api/v1alpha2/keptnapp_types.go 91.66% <0.00%> (ø)
operator/api/v1alpha2/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
...ator/api/v1alpha2/keptnevaluationprovider_types.go 100.00% <0.00%> (ø)
operator/controllers/keptnevaluation/controller.go 0.00% <0.00%> (ø)
...controllers/keptnevaluation/providers/dynatrace.go 82.25% <0.00%> (ø)
operator/controllers/keptnevaluation/common.go 100.00% <0.00%> (ø)
...ontrollers/keptnevaluation/providers/prometheus.go 91.89% <0.00%> (ø)
.../controllers/keptnevaluation/providers/provider.go 100.00% <0.00%> (ø)
Flag Coverage Δ
component-tests 51.36% <ø> (ø)
keptn-lifecycle-operator 47.07% <ø> (-0.21%) ⬇️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl marked this pull request as ready for review December 14, 2022 06:32
@thschue
Copy link
Contributor

thschue commented Dec 14, 2022

this should be changed in the dashboards under /dashboards/grafana and afterward regenerated (make generate).

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes have to be made in the dashboards under dashboards/grafana and the configmaps regenerated afterward.

Signed-off-by: Florian Bacher <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thschue thschue self-requested a review December 14, 2022 07:21
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bacherfl bacherfl merged commit 8cdb23e into keptn:main Dec 16, 2022
@bacherfl bacherfl deleted the fix/496/dashboard-color branch December 16, 2022 07:14
@keptn-bot keptn-bot mentioned this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard :: Success deployments is shown in red if more than 80 deployments
3 participants