chore: enhance golangci-lint with code complexity and other measures #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mowies
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
==========================================
+ Coverage 59.68% 60.95% +1.26%
==========================================
Files 28 30 +2
Lines 2101 2177 +76
==========================================
+ Hits 1254 1327 +73
- Misses 743 745 +2
- Partials 104 105 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Moritz Wiesinger <[email protected]> remove redundant newlines Signed-off-by: Moritz Wiesinger <[email protected]> remove code quality tools reporting Signed-off-by: Moritz Wiesinger <[email protected]> adjust funlen go linter Signed-off-by: Moritz Wiesinger <[email protected]> also trigger golangci-lint on pushes to main and maintenance branches Signed-off-by: Moritz Wiesinger <[email protected]> set up complexity and function length measure for golangci-lint Signed-off-by: Moritz Wiesinger <[email protected]> comment in stuff Signed-off-by: Moritz Wiesinger <[email protected]> more debugging Signed-off-by: Moritz Wiesinger <[email protected]> more debugging Signed-off-by: Moritz Wiesinger <[email protected]> debugging Signed-off-by: Moritz Wiesinger <[email protected]> remove trailing slashes Signed-off-by: Moritz Wiesinger <[email protected]> remove prefixes on coverage reports Signed-off-by: Moritz Wiesinger <[email protected]> even more trys Signed-off-by: Moritz Wiesinger <[email protected]> one more Signed-off-by: Moritz Wiesinger <[email protected]> another try... Signed-off-by: Moritz Wiesinger <[email protected]> fix coverage files in makefile Signed-off-by: Moritz Wiesinger <[email protected]> one more try Signed-off-by: Moritz Wiesinger <[email protected]> remove lines that are not needed again Signed-off-by: Moritz Wiesinger <[email protected]> remove unneeded lines from coverage reports Signed-off-by: Moritz Wiesinger <[email protected]> comment out stuff Signed-off-by: Moritz Wiesinger <[email protected]> upload to code climate as well Signed-off-by: Moritz Wiesinger <[email protected]> adjust path Signed-off-by: Moritz Wiesinger <[email protected]> set up token correctly Signed-off-by: Moritz Wiesinger <[email protected]> rename Signed-off-by: Moritz Wiesinger <[email protected]> change coverage reporting Signed-off-by: Moritz Wiesinger <[email protected]> remove bug Signed-off-by: Moritz Wiesinger <[email protected]> report coverage to codacy Signed-off-by: Moritz Wiesinger <[email protected]>
mowies
requested review from
thisthat,
thschue,
bacherfl,
RealAnna and
philipp-hinteregger
as code owners
Signed-off-by: Moritz Wiesinger <[email protected]>
mowies
force-pushed
the
enhance-golinter
branch
from
a7cb2f5 to
2babde5
Compare
Closed
odubajDT
reviewed
Nov 30, 2022
|
looks good, but is there maybe a possibility to disable the checks on the *_test.go files ? Now we have errors that some test functions are too long, which is completely ok for us, as we are mostly using table tests |
Signed-off-by: Moritz Wiesinger <[email protected]>
Co-authored-by: odubajDT <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]>
odubajDT
previously approved these changes
Nov 30, 2022
philipp-hinteregger
previously approved these changes
Nov 30, 2022
Signed-off-by: Moritz Wiesinger <[email protected]>
mowies
dismissed stale reviews from philipp-hinteregger and odubajDT
via
427df59
philipp-hinteregger
previously approved these changes
Dec 1, 2022
odubajDT
previously approved these changes
Dec 1, 2022
Signed-off-by: Moritz Wiesinger <[email protected]>
mowies
dismissed stale reviews from odubajDT and philipp-hinteregger
via
d93a4e6
Signed-off-by: Moritz Wiesinger <[email protected]>
thisthat
previously approved these changes
Dec 1, 2022
odubajDT
previously approved these changes
Dec 1, 2022
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
thisthat
approved these changes
Dec 1, 2022
odubajDT
approved these changes
Dec 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
cyclop: Measures and limits cyclomatic complexitygocognit: Measures and limits cognitive complexityfunlen: Limits function line and statement lengthtestcommands to return aggregated and fully syntactically correct coverage reportsNotes:
Closes #462
Linter issues will be fixed in #485.