fix: adapt name of keptn_app_count metric due to reverted OTel exporter dependency update #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er dependency update Signed-off-by: Florian Bacher <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
+ Coverage 59.54% 59.82% +0.28%
==========================================
Files 28 28
Lines 2101 2101
==========================================
+ Hits 1251 1257 +6
+ Misses 745 741 -4
+ Partials 105 103 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
bacherfl
changed the title
keptn_app_count metric due to reverted OTel exporter dependency update
bacherfl
changed the title
keptn_app_count metric due to reverted OTel exporter dependency update
odubajDT
reviewed
Nov 30, 2022
examples/observability/config/prometheus/grafana-dashboard-keptn-applications.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: odubajDT <[email protected]> Signed-off-by: Florian Bacher <[email protected]>
odubajDT
approved these changes
Nov 30, 2022
thisthat
approved these changes
Nov 30, 2022
Merged
bacherfl
added a commit
to bacherfl/lifecycle-controller
that referenced
this pull request
Dec 19, 2022
…l exporter dependency update (keptn#482)" This reverts commit 97f8e8c. Signed-off-by: Florian Bacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we had to revert the recent upgrade to the OpenTelemetry prometheus exporter (see #447), the metric for the total number of applications was
keptn_app_countagain instead ofkeptn_app_count_totalSigned-off-by: Florian Bacher [email protected]