Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct namespace variable in delete cmd #446

Merged
merged 3 commits into from
Nov 21, 2022
Merged

fix: use correct namespace variable in delete cmd #446

merged 3 commits into from
Nov 21, 2022

Conversation

mowies
Copy link
Member

@mowies mowies commented Nov 21, 2022

This PR

  • fixes a tiny bug in the Argo example where the argo namespace gets deleted. The wrong variable was used there.

@codecov
Copy link

codecov bot commented Nov 21, 2022 •
edited
Loading

Codecov Report

Merging #446 (9f6f18a) into main (fdf3f4b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   32.84%   32.84%           
=======================================
  Files          19       19           
  Lines        1516     1516           
=======================================
  Hits          498      498           
  Misses        989      989           
  Partials       29       29
Flag Coverage Δ
keptn-lifecycle-operator 37.68% <ø> (ø)
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

thschue
thschue approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mowies mowies changed the title fix: Use correct namespace variable in delete cmd fix: use correct namespace variable in delete cmd Nov 21, 2022
@mowies
trigger build
9f6f18a 
Signed-off-by: Moritz Wiesinger <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mowies mowies merged commit c3b2188 into keptn:main Nov 21, 2022
@mowies mowies deleted the fix-argo-example branch November 21, 2022 07:44
@keptn-bot keptn-bot mentioned this pull request Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna approved these changes

@thschue thschue thschue approved these changes

@thisthat thisthat Awaiting requested review from thisthat

@bacherfl bacherfl Awaiting requested review from bacherfl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mowies @thschue @RealAnna