Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operator): include detailed information about task/evaluation failure in span #445

Merged
merged 12 commits into from
Nov 22, 2022
Merged

feat(operator): include detailed information about task/evaluation failure in span #445

merged 12 commits into from
Nov 22, 2022

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 20, 2022 •
edited
Loading

Fixes: #396
Screenshot from 2022-11-21 07-56-43
Screenshot from 2022-11-21 11-10-35

@codecov
Copy link

codecov bot commented Nov 20, 2022 •
edited
Loading

Codecov Report

Merging #445 (834c127) into main (24efc80) will increase coverage by 1.30%.
The diff coverage is 80.30%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   37.99%   39.29%   +1.30%     
==========================================
  Files          28       28              
  Lines        2082     2148      +66     
==========================================
+ Hits          791      844      +53     
- Misses       1227     1237      +10     
- Partials       64       67       +3
Impacted Files Coverage Δ
operator/controllers/common/phasehandler.go 78.94% <80.30%> (+1.33%) ⬆️
Flag Coverage Δ
keptn-lifecycle-operator 43.27% <80.30%> (+1.31%) ⬆️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT changed the title feat(operator): include detailed information about evaluation failure in span feat(operator): include detailed information about task/evaluation failure in span Nov 21, 2022
@odubajDT odubajDT marked this pull request as ready for review November 21, 2022 10:47
@thschue
Copy link
Contributor

thschue commented Nov 21, 2022

It seems like there are some issues in your screenshots, e.g.
image

Is this already fixed?

@odubajDT
Copy link
Contributor Author

odubajDT commented Nov 21, 2022 •
edited
Loading

It seems like there are some issues in your screenshots, e.g. image

Is this already fixed?

maybe it's due to that I am building my images locally ? It certainly does not seem like I introduced it now...

thisthat
thisthat reviewed Nov 21, 2022
View reviewed changes
operator/controllers/common/phasehandler.go Outdated Show resolved Hide resolved
operator/controllers/common/phasehandler.go Outdated Show resolved Hide resolved
operator/controllers/common/phasehandler.go Outdated Show resolved Hide resolved
operator/controllers/common/phasehandler.go Outdated Show resolved Hide resolved
operator/controllers/common/phasehandler.go Outdated Show resolved Hide resolved
@RealAnna
Copy link
Contributor

RealAnna commented Nov 21, 2022 •
edited
Loading

It seems like there are some issues in your screenshots, e.g. image
Is this already fixed?

maybe it's due to that I am building my images locally ? It certainly does not seem like I introduced it now...

I found this also on v0.4 so would be better to tackle this as a separate bug
image

@odubajDT
Copy link
Contributor Author

It seems like there are some issues in your screenshots, e.g. image
Is this already fixed?

maybe it's due to that I am building my images locally ? It certainly does not seem like I introduced it now...

I found this also on v0.4 so would be better to tackle this as a separate bug image

@thschue

@odubajDT
first draft
867fa92 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
not possible to fetch failed job data
af6f869 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
first version
0e58762 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
added tests for phases
6e682bb 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
support task failure spans
9430976 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
renaming
10bf4ce 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
added unit tests
91f31f0 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
pr review
afa701a 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
rebase
ee7920c 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fixed error msg
7bf4817 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
pr review
dedd2dc 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
minor fix
834c127 
Signed-off-by: odubajDT <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

thschue
thschue approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 94de8d6 into keptn:main Nov 22, 2022
@keptn-bot keptn-bot mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisthat thisthat thisthat left review comments

@thschue thschue thschue approved these changes

@bacherfl bacherfl bacherfl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass details on why evaluations or tasks fail
5 participants
@odubajDT @thschue @RealAnna @thisthat @bacherfl