Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(operator): increment the correct meter to show deployment count #434

Merged
merged 11 commits into from
Nov 22, 2022
Merged

fix(operator): increment the correct meter to show deployment count #434

merged 11 commits into from
Nov 22, 2022

Conversation

mowies
Copy link
Member

@mowies mowies commented Nov 17, 2022 •
edited
Loading

This PR

  • fixes a small bug that was actually a typo in the end
  • adds unit tests
  • adds test_utils.go to the codecov ignore list

Fixes #416

@mowies mowies marked this pull request as ready for review November 17, 2022 15:20
@mowies mowies marked this pull request as draft November 17, 2022 15:20
@mowies mowies changed the title fix: Increment the corrent meter to show deployment count fix: increment the correct meter to show deployment count Nov 17, 2022
@odubajDT odubajDT mentioned this pull request Nov 18, 2022
Closed
@mowies mowies force-pushed the fix/416/deployment-count branch from 4c62b18 to a366f51 Compare November 21, 2022 07:16
@codecov
Copy link

codecov bot commented Nov 21, 2022 •
edited
Loading

Codecov Report

Merging #434 (edaf1b9) into main (24efc80) will increase coverage by 3.98%.
The diff coverage is 50.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
+ Coverage   37.99%   41.97%   +3.98%     
==========================================
  Files          28       27       -1     
  Lines        2082     2056      -26     
==========================================
+ Hits          791      863      +72     
+ Misses       1227     1114     -113     
- Partials       64       79      +15
Impacted Files Coverage Δ
...or/controllers/keptnworkloadinstance/controller.go 47.17% <50.00%> (+36.92%) ⬆️
operator/controllers/common/test_utils.go
Flag Coverage Δ
keptn-lifecycle-operator 46.48% <50.00%> (+4.51%) ⬆️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies
fix: Increment the corrent meter to show deployment count
b84023f 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
trigger build
b7e3b86 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix typo
cd95acd 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
first unit tests
e57f53f 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies force-pushed the fix/416/deployment-count branch from ec458d5 to e57f53f Compare November 21, 2022 12:08
@mowies
refactoring
1645a6e 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
add possibility to add workloads
ba6879b 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
add workload
48a15fc 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
add succeeded states
6955f28 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
move initMeters func to test utils, make use of it and check events i…
7afa2b9 
…n unit test

Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
ignore test_utils.go in coverage
1745781 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
ignore test_utils.go in coverage
edaf1b9 
Signed-off-by: Moritz Wiesinger <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies marked this pull request as ready for review November 21, 2022 13:48
@mowies mowies changed the title fix: increment the correct meter to show deployment count fix(operator): increment the correct meter to show deployment count Nov 21, 2022
odubajDT
odubajDT approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good work! :)

@mowies mowies merged commit 0287596 into keptn:main Nov 22, 2022
@mowies mowies deleted the fix/416/deployment-count branch November 22, 2022 08:39
@keptn-bot keptn-bot mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@bacherfl bacherfl bacherfl approved these changes

@thisthat thisthat Awaiting requested review from thisthat

@thschue thschue Awaiting requested review from thschue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metric keptn_deployment_count is missing
3 participants
@mowies @bacherfl @odubajDT