Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics exported with wrong name (keptn_app_count_total) #415

Closed
thschue opened this issue Nov 15, 2022 · 3 comments · Fixed by #447
Closed

Metrics exported with wrong name (keptn_app_count_total) #415

thschue opened this issue Nov 15, 2022 · 3 comments · Fixed by #447
Assignees
Labels
bug Something isn't working
Milestone

Comments

@thschue
Copy link
Contributor

thschue commented Nov 15, 2022

The metric 'keptn_app_count_total' seems to have naming issues, as it exists multiple times with '_total' appended every time. This leads to incorrect calculations in the dashboards.

keptn_app_count_total{keptn_deployment_app_name="podtato-head",keptn_deployment_workload_name="podtato-head-podtato-head-left-leg",keptn_deployment_workload_namespace="podtato-kubectl",keptn_deployment_workload_status="Succeeded",keptn_deployment_workload_version="0.2.7"} 1
# HELP keptn_app_count_total_total a simple counter for Keptn Apps
# TYPE keptn_app_count_total_total counter
keptn_app_count_total_total{keptn_deployment_app_name="podtato-head",keptn_deployment_workload_name="podtato-head-podtato-head-right-arm",keptn_deployment_workload_namespace="podtato-kubectl",keptn_deployment_workload_status="Succeeded",keptn_deployment_workload_version="0.1.0"} 1
# HELP keptn_app_count_total_total_total a simple counter for Keptn Apps
# TYPE keptn_app_count_total_total_total counter
keptn_app_count_total_total_total{keptn_deployment_app_name="podtato-head",keptn_deployment_app_namespace="podtato-kubectl",keptn_deployment_app_status="Succeeded",keptn_deployment_app_version="0.1.1"} 1
# HELP keptn_app_count_total_total_total_total a simple counter for Keptn Apps
# TYPE keptn_app_count_total_total_total_total counter
keptn_app_count_total_total_total_total{keptn_deployment_app_name="podtato-head",keptn_deployment_app_namespace="podtato-kubectl",keptn_deployment_app_status="Succeeded",keptn_deployment_app_version="0.1.2"} 1
# HELP keptn_app_count_total_total_total_total_total a simple counter for Keptn Apps
# TYPE keptn_app_count_total_total_total_total_total counter
keptn_app_count_total_total_total_total_total{keptn_deployment_app_name="podtato-head",keptn_deployment_app_namespace="podtato-kubectl",keptn_deployment_app_status="Failed",keptn_deployment_app_version="0.1.0"} 1
# HELP keptn_app_count_total_total_total_total_total_total a simple counter for Keptn Apps
# TYPE keptn_app_count_total_total_total_total_total_total counter
keptn_app_count_total_total_total_total_total_total{keptn_deployment_app_name="podtato-head",keptn_deployment_workload_name="podtato-head-podtato-head-entry",keptn_deployment_workload_namespace="podtato-kubectl",keptn_deployment_workload_status="Succeeded",keptn_deployment_workload_version="0.2.7"} 1
# HELP keptn_app_count_total_total_total_total_total_total_total a simple counter for Keptn Apps
# TYPE keptn_app_count_total_total_total_total_total_total_total counter
keptn_app_count_total_total_total_total_total_total_total{keptn_deployment_app_name="podtato-head",keptn_deployment_workload_name="podtato-head-podtato-head-right-leg",keptn_deployment_workload_namespace="podtato-kubectl",keptn_deployment_workload_status="Succeeded",keptn_deployment_workload_version="0.2.7"} 1
# HELP keptn_app_count_total_total_total_total_total_total_total_total a simple counter for Keptn Apps
# TYPE keptn_app_count_total_total_total_total_total_total_total_total counter
keptn_app_count_total_total_total_total_total_total_total_total{keptn_deployment_app_name="podtato-head",keptn_deployment_workload_name="podtato-head-podtato-head-left-arm",keptn_deployment_workload_namespace="podtato-kubectl",keptn_deployment_workload_status="Succeeded",keptn_deployment_workload_version="0.2.7"} 1
# HELP keptn_app_count_total_total_total_total_total_total_total_total_total a simple counter for Keptn Apps
# TYPE keptn_app_count_total_total_total_total_total_total_total_total_total counter
keptn_app_count_total_total_total_total_total_total_total_total_total{keptn_deployment_app_name="podtato-head",keptn_deployment_app_namespace="podtato-kubectl",keptn_deployment_app_status="Failed",keptn_deployment_app_version="0.1.4"} 1
# HELP keptn_app_count_total_total_total_total_total_total_total_total_total_total a simple counter for Keptn Apps
# TYPE keptn_app_count_total_total_total_total_total_total_total_total_total_total counter
keptn_app_count_total_total_total_total_total_total_total_total_total_total{keptn_deployment_app_name="podtato-head",keptn_deployment_workload_name="podtato-head-podtato-head-hat",keptn_deployment_workload_namespace="podtato-kubectl",keptn_deployment_workload_status="Succeeded",keptn_deployment_workload_version="0.1.0"} 1
# HELP keptn_app_count_total_total_total_total_total_total_total_total_total_total_total a simple counter for Keptn Apps
# TYPE keptn_app_count_total_total_total_total_total_total_total_total_total_total_total counter
keptn_app_count_total_total_total_total_total_total_total_total_total_total_total{keptn_deployment_app_name="podtato-head",keptn_deployment_workload_name="podtato-head-podtato-head-hat",keptn_deployment_workload_namespace="podtato-kubectl",keptn_deployment_workload_status="Succeeded",keptn_deployment_workload_version="0.1.1"} 1
@odubajDT
Copy link
Contributor

The problem is caused by OTel sdk, which was introduced here:
open-telemetry/opentelemetry-go@1d9d4b2

and afterwards fixed here:
open-telemetry/opentelemetry-go@ccbc38e

The fixed version is not released yet, so either we will wait for the bugfix release, or we use master version.

@bacherfl thx for finding the real cause of the problem :)

@odubajDT odubajDT added the on hold Do not merge yet label Nov 18, 2022
@odubajDT
Copy link
Contributor

Putting this bug on hold, until the next release of OTel

@thisthat thisthat modified the milestones: 0.4.1, 0.5.x Nov 18, 2022
@odubajDT odubajDT moved this from 🏃 In progress to ✅ Done in Keptn Lifecycle Toolkit Nov 22, 2022
@odubajDT
Copy link
Contributor

Fixed via #447

@odubajDT odubajDT removed the on hold Do not merge yet label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants