Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added back permission to list and watch namespaces #404

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

RealAnna
Copy link
Contributor

Signed-off-by: RealAnna [email protected]

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #404 (e4af830) into main (c21f015) will increase coverage by 1.22%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   24.93%   26.15%   +1.22%     
==========================================
  Files          16       16              
  Lines        1488     1495       +7     
==========================================
+ Hits          371      391      +20     
+ Misses       1099     1086      -13     
  Partials       18       18              
Impacted Files Coverage Δ
operator/webhooks/pod_mutating_webhook.go 36.22% <ø> (ø)
...or/controllers/keptnworkloadinstance/controller.go 10.25% <0.00%> (+10.25%) ⬆️
Flag Coverage Δ
keptn-lifecycle-operator 29.90% <ø> (+1.41%) ⬆️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

thschue
thschue previously approved these changes Nov 14, 2022
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RealAnna RealAnna merged commit df346f7 into main Nov 14, 2022
@RealAnna RealAnna deleted the fix/deduce_app_check branch November 14, 2022 12:39
@keptn-bot keptn-bot mentioned this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants