Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add cert-manager installation instructions to README #392

Merged
merged 1 commit into from
Nov 11, 2022
Merged

docs: add cert-manager installation instructions to README #392

merged 1 commit into from
Nov 11, 2022

Conversation

thschue
Copy link
Contributor

@thschue thschue commented Nov 11, 2022

Signed-off-by: Thomas Schuetz [email protected]

@thschue thschue added this to the 0.4.1 milestone Nov 11, 2022
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #392 (1b6cf04) into main (a3a0600) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   19.45%   19.45%           
=======================================
  Files          13       13           
  Lines        1074     1074           
=======================================
  Hits          209      209           
  Misses        850      850           
  Partials       15       15           
Flag Coverage Δ
keptn-lifecycle-operator 23.32% <ø> (ø)
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

README.md Show resolved Hide resolved
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not fully happy with maintaining a version check in our main readme but I understand your concerns @thschue since it is a hard dependency that we have at the moment.
We should prioritise #393 to search for alternatives.

@thschue thschue merged commit 58161a1 into keptn:main Nov 11, 2022
@thschue thschue deleted the chore/install_cert_manager branch November 11, 2022 10:37
@keptn-bot keptn-bot mentioned this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants