Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update module github.com/prometheus/client_golang to v1.20.5 #3809

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 29, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/prometheus/client_golang v1.20.4 -> v1.20.5 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

prometheus/client_golang (github.com/prometheus/client_golang)

v1.20.5: / 2024-10-15

Compare Source

We decided to revert the testutil change that made our util functions less error-prone, but created a lot of work for our downstream users. Apologies for the pain! This revert should not cause any major breaking change, even if you already did the work--unless you depend on the exact error message.

Going forward, we plan to reinforce our release testing strategy [1],[2] and deliver an enhanced testutil package/module with more flexible and safer APIs.

Thanks to @​dashpole @​dgrisonnet @​kakkoyun @​ArthurSens @​vesari @​logicalhan @​krajorama @​bwplotka who helped in this patch release! 🤗

Changelog

[BUGFIX] testutil: Reverted #​1424; functions using compareMetricFamilies are (again) only failing if filtered metricNames are in the expected input. #​1645


Configuration

📅 Schedule: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" in timezone Europe/Vienna, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot requested a review from a team as a code owner October 29, 2024 21:42
Copy link

sonarcloud bot commented Oct 29, 2024

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.68%. Comparing base (2c5ba22) to head (55fc493).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3809      +/-   ##
==========================================
- Coverage   76.72%   76.68%   -0.05%     
==========================================
  Files         224      224              
  Lines       11883    11883              
==========================================
- Hits         9117     9112       -5     
- Misses       2398     2402       +4     
- Partials      368      369       +1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 47.44% <ø> (ø)
component-tests 79.40% <ø> (-0.32%) ⬇️
lifecycle-operator 79.69% <ø> (ø)
metrics-operator 75.91% <ø> (ø)
scheduler 36.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT merged commit 3d72aa0 into main Nov 4, 2024
38 checks passed
@odubajDT odubajDT deleted the renovate/github.com-prometheus-client_golang-1.20.x branch November 4, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant