Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify OTel collector usage in getting started guide #3775

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

Garvit-77
Copy link
Contributor

Summary

Reformatting the architecture diagram
adding note in getting started

Fixes #3538

Checks

  • [] My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)(
    see Contribution Guide)
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My content follows the style guidelines of this project (YAMLLint, markdown-lint)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my content including grammar and typo errors and also checked the rendered page
    from the Netlify deploy preview
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)

@Garvit-77 Garvit-77 requested review from a team as code owners October 22, 2024 08:01
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 22, 2024
@mowies mowies changed the title issue-3538 docs: clarify OTel collector usage in getting started guide Oct 22, 2024
docs/docs/getting-started/observability.md Outdated Show resolved Hide resolved
docs/docs/getting-started/assets/Keptn.png Outdated Show resolved Hide resolved
Garvit-77 and others added 4 commits October 28, 2024 21:50
Signed-off-by: Garvit Khandelwal <[email protected]>
Signed-off-by: Garvit Khandelwal <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Garvit Khandelwal <[email protected]>
Signed-off-by: Garvit Khandelwal <[email protected]>
Copy link

Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mowies mowies merged commit 489f593 into keptn:main Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify how otel data is processed internally
3 participants