-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify OTel collector usage in getting started guide #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Oct 22, 2024
mowies
changed the title
issue-3538
docs: clarify OTel collector usage in getting started guide
Oct 22, 2024
mowies
reviewed
Oct 22, 2024
mowies
reviewed
Oct 23, 2024
mowies
reviewed
Oct 23, 2024
Signed-off-by: Garvit Khandelwal <[email protected]>
Signed-off-by: Garvit Khandelwal <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Garvit Khandelwal <[email protected]>
Garvit-77
force-pushed
the
keptn-#3538
branch
from
October 28, 2024 16:20
58ce8f7
to
583bdb7
Compare
Signed-off-by: Garvit Khandelwal <[email protected]>
Quality Gate passedIssues Measures |
mowies
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
odubajDT
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reformatting the architecture diagram
adding note in getting started
Fixes #3538
Checks
into multiple PRs)
see Contribution Guide)
the Contribution Guide
from the Netlify deploy preview