Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain that part-of and name annotations are concatenated #3540

Closed
StackScribe opened this issue May 28, 2024 · 6 comments · Fixed by #3778
Closed

Explain that part-of and name annotations are concatenated #3540

StackScribe opened this issue May 28, 2024 · 6 comments · Fixed by #3778
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers status: in-progress

Comments

@StackScribe
Copy link
Contributor

StackScribe commented May 28, 2024

Summary

The response to https://cloud-native.slack.com/archives/C017GAX90GM/p1715855191882149 expands on the following information from the Basic annotations:

  • If only the workload and version annotations/labels are available (in other words, neither the keptn.sh/app or app.kubernetes.io/part-of annotation/label is populated), Keptn creates a KeptnApp resource for each KeptnWorkload and your observability output traces the individual Keptnworkload resources but not the combined workloads that constitute your deployed application.

And on the architectural information in How basic annotations are implemented.

DoD

Update Basic annotations and/or How basic annotations are implemented to include text such as the following:

Note: Keptn application discovery concatenates the values of the app.kubernetes.io/name or keptn.sh/workload
and app.kubernetes.io/part-of or keptn.sh/app annotation to determine the name of the KeptnWorkload.
It does this by concatenating these two values:

Insert the note here

@StackScribe StackScribe added documentation Improvements or additions to documentation status: draft good first issue Good for newcomers status: ready-for-refinement Issue is relevant for the next backlog refinment and removed status: draft labels May 28, 2024
@RealAnna RealAnna added status: todo and removed status: ready-for-refinement Issue is relevant for the next backlog refinment labels May 29, 2024
@shardulsrivastava
Copy link
Contributor

@StackScribe I would like to work on this issue, can you please assign it to me.

@mowies
Copy link
Member

mowies commented Jul 29, 2024

sure @shardulsrivastava !
I also updated the ticket description a little bit.

Copy link
Contributor

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

@mowies
Copy link
Member

mowies commented Oct 10, 2024

un-assigning, due to inactivity

@Garvit-77
Copy link
Contributor

@mowies I would like to work on this issue

@mowies
Copy link
Member

mowies commented Oct 23, 2024

sure thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers status: in-progress
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants