-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics-operator): introduce v1 API version #3266
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3266 +/- ##
==========================================
+ Coverage 87.05% 87.06% +0.01%
==========================================
Files 162 168 +6
Lines 8665 8705 +40
==========================================
+ Hits 7543 7579 +36
- Misses 831 836 +5
+ Partials 291 290 -1
... and 6 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking this for now since we don't wanna merge this yet, cus of a potential bugfix release in the charts
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: odubajDT <[email protected]> Signed-off-by: odubajDT <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Fixes: #3238
Changes
v1
version are addedNotes
Load tests are failing due to missing conversion webhook
v1beta1
->v1
, after adaptation the operator logic, the test are passing, see here