Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): introduce v1 API version #3266

Merged
merged 6 commits into from
Mar 21, 2024
Merged

feat(metrics-operator): introduce v1 API version #3266

merged 6 commits into from
Mar 21, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Mar 14, 2024

Fixes: #3238

Changes

  • new CRDs in v1 version are added
  • CRDs are added to helm charts
  • helm tests are updated
  • readme badge is updated

Notes

Load tests are failing due to missing conversion webhook v1beta1 -> v1, after adaptation the operator logic, the test are passing, see here

@github-actions github-actions bot added documentation Improvements or additions to documentation ops metrics-operator labels Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 87.06%. Comparing base (d4cf6d0) to head (bf8999e).
Report is 5 commits behind head on main.

❗ Current head bf8999e differs from pull request most recent head 19c0b0e. Consider uploading reports for the commit 19c0b0e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3266      +/-   ##
==========================================
+ Coverage   87.05%   87.06%   +0.01%     
==========================================
  Files         162      168       +6     
  Lines        8665     8705      +40     
==========================================
+ Hits         7543     7579      +36     
- Misses        831      836       +5     
+ Partials      291      290       -1     
Files Coverage Δ
metrics-operator/api/v1/analysis_types.go 100.00% <100.00%> (ø)
...etrics-operator/api/v1/analysisdefinition_types.go 100.00% <100.00%> (ø)
...ics-operator/api/v1/analysisvaluetemplate_types.go 100.00% <100.00%> (ø)
metrics-operator/api/v1/common.go 100.00% <100.00%> (ø)
metrics-operator/api/v1/keptnmetric_types.go 100.00% <100.00%> (ø)
...rics-operator/api/v1/keptnmetricsprovider_types.go 66.66% <66.66%> (ø)

... and 6 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 57.81% <ø> (-0.96%) ⬇️
lifecycle-operator 86.75% <ø> (+0.24%) ⬆️
metrics-operator 88.35% <89.65%> (+0.03%) ⬆️
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review March 14, 2024 13:29
@odubajDT odubajDT requested review from a team as code owners March 14, 2024 13:29
@odubajDT odubajDT added the on hold Do not merge yet label Mar 14, 2024
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking this for now since we don't wanna merge this yet, cus of a potential bugfix release in the charts

@odubajDT odubajDT requested a review from mowies March 20, 2024 14:39
mowies
mowies previously approved these changes Mar 21, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@odubajDT odubajDT merged commit d034a4f into keptn:main Mar 21, 2024
43 of 44 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation metrics-operator on hold Do not merge yet ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create API, adapt readme, re-generate API docs, update helm chart
3 participants