fix: assert keptn-cert-manager integration test more precisely #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: odubajDT <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3258 +/- ##
==========================================
- Coverage 87.07% 87.00% -0.07%
==========================================
Files 162 162
Lines 8647 8647
==========================================
- Hits 7529 7523 -6
- Misses 828 832 +4
- Partials 290 292 +2 see 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
mowies
approved these changes
Mar 13, 2024
thisthat
approved these changes
Mar 13, 2024
Vickysomtee
pushed a commit
to Vickysomtee/keptn-lifecycle-toolkit
that referenced
this pull request
Apr 23, 2024
…#3258) Signed-off-by: odubajDT <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the
testcertificateintegration test does restartlifecycle-operatorandmetrics-operatorDeployments, it should properly assert that the pods are running after the restart. If this is not the case after the restart -> chainsaw continues with another test (non-blocking-deployment), but since the pods are not yet up and running, it fails.Also there was a need to increase the
execTimeoutin the chainsaw configuration to allow the scripts with retry logic to be executed for longer than the default 5s