Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics-operator): remove duplicated CA injection annotations #3232

Merged
merged 2 commits into from
Mar 11, 2024
Merged

fix(metrics-operator): remove duplicated CA injection annotations #3232

merged 2 commits into from
Mar 11, 2024

Conversation

odubajDT
Copy link
Contributor

Fixes: #3226

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.02%. Comparing base (23f6543) to head (19fd28b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3232      +/-   ##
==========================================
+ Coverage   87.00%   87.02%   +0.02%     
==========================================
  Files         162      162              
  Lines        8647     8647              
==========================================
+ Hits         7523     7525       +2     
+ Misses        832      831       -1     
+ Partials      292      291       -1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.22% <ø> (+0.74%) ⬆️
lifecycle-operator 86.75% <ø> (ø)
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT marked this pull request as ready for review March 11, 2024 13:52
@odubajDT odubajDT requested a review from a team as a code owner March 11, 2024 13:52
mowies
mowies previously approved these changes Mar 11, 2024
bacherfl
bacherfl previously approved these changes Mar 11, 2024
@odubajDT odubajDT dismissed stale reviews from bacherfl and mowies via e0c2f7b March 11, 2024 14:02
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT merged commit c1472be into keptn:main Mar 11, 2024
65 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Helm Chart when trying to use cert-manager.io
3 participants