chore: use binding in keptn metric test #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3172 +/- ##
=======================================
Coverage 87.00% 87.00%
=======================================
Files 162 162
Lines 8647 8647
=======================================
Hits 7523 7523
Misses 832 832
Partials 292 292
Flags with carried forward coverage won't be shown. Click here to find out more. |
eddycharly
force-pushed
the
svc-binding
branch
4 times, most recently
from
bde65b6 to
be27b43
Compare
|
Will need kyverno/chainsaw#1023 |
eddycharly
force-pushed
the
svc-binding
branch
3 times, most recently
from
aa11723 to
5561461
Compare
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
|
odubajDT
changed the title
odubajDT
approved these changes
Mar 5, 2024
bacherfl
approved these changes
Mar 6, 2024
bacherfl
pushed a commit
to bacherfl/lifecycle-controller
that referenced
this pull request
Mar 7, 2024
Signed-off-by: Charles-Edouard Brétéché <[email protected]> Signed-off-by: Florian Bacher <[email protected]>
Vickysomtee
pushed a commit
to Vickysomtee/keptn-lifecycle-toolkit
that referenced
this pull request
Apr 23, 2024
Signed-off-by: Charles-Edouard Brétéché <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of chainsaw bindings to lookup the metrics-operator service and uses it to apply a resource template instead of doing everything with a script.