Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove disabled linter #3084

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

geoffrey1330
Copy link
Member

Fixes #1248

Checks

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)(
    see Contribution Guide)
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My content follows the style guidelines of this project (YAMLLint, markdown-lint)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my content including grammar and typo errors and also checked the rendered page
    from the Netlify deploy preview
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)

Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330 geoffrey1330 requested review from a team as code owners February 20, 2024 10:12
@github-actions github-actions bot added documentation Improvements or additions to documentation metrics-operator labels Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce57993) 85.75% compared to head (431af92) 83.10%.
Report is 58 commits behind head on main.

❗ Current head 431af92 differs from pull request most recent head d1c855b. Consider uploading reports for the commit d1c855b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
- Coverage   85.75%   83.10%   -2.65%     
==========================================
  Files         162      119      -43     
  Lines       10351     6250    -4101     
==========================================
- Hits         8876     5194    -3682     
+ Misses       1186      850     -336     
+ Partials      289      206      -83     

see 144 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (+1.80%) ⬆️
component-tests ?
keptn-lifecycle-operator ?
lifecycle-operator 86.40% <ø> (+1.11%) ⬆️
metrics-operator ?
scheduler 34.74% <ø> (-1.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@RealAnna RealAnna merged commit 0bb9a36 into keptn:main Feb 20, 2024
10 checks passed
Bharadwajshivam28 pushed a commit to Bharadwajshivam28/lifecycle-toolkit that referenced this pull request Feb 20, 2024
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to write / create a new KeptnMetricsProvider
3 participants