Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix indentation issues and adjust linter rules #3028

Merged
merged 13 commits into from
Feb 14, 2024

Conversation

mowies
Copy link
Member

@mowies mowies commented Feb 12, 2024

This PR

  • fixes the markdownlint rule so that lists (unordered and ordered) will be rendered correctly
  • changes the list indentation rule for MDL to 4 spaces to correctly render lists on the website

NOTE: multi-paragraph list items are special as any paragraph in a list item needs to be indented like it's a nested list item

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@github-actions github-actions bot added documentation Improvements or additions to documentation metrics-operator labels Feb 12, 2024
This reverts commit b059ada.

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce57993) 85.75% compared to head (3c7021e) 86.73%.
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3028      +/-   ##
==========================================
+ Coverage   85.75%   86.73%   +0.98%     
==========================================
  Files         162      162              
  Lines       10351     8514    -1837     
==========================================
- Hits         8876     7385    -1491     
+ Misses       1186      839     -347     
- Partials      289      290       +1     

see 139 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (+1.80%) ⬆️
component-tests 56.87% <ø> (+0.87%) ⬆️
lifecycle-operator 86.39% <ø> (+1.10%) ⬆️
metrics-operator 88.32% <ø> (+0.68%) ⬆️
scheduler 34.74% <ø> (-1.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Moritz Wiesinger <[email protected]>
# Conflicts:
#	docs/docs/contribute/general/technologies.md
#	docs/docs/reference/crd-reference/taskdefinition.md
@mowies mowies changed the title docs: fix indentation issues docs: fix indentation issues and adjust linter rules Feb 13, 2024
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies marked this pull request as ready for review February 13, 2024 13:03
@mowies mowies requested review from a team as code owners February 13, 2024 13:03
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mowies mowies merged commit 034dae3 into keptn:main Feb 14, 2024
34 checks passed
@mowies mowies deleted the mdl-fixes branch February 14, 2024 06:51
Bharadwajshivam28 pushed a commit to Bharadwajshivam28/lifecycle-toolkit that referenced this pull request Feb 20, 2024
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation metrics-operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants