chore: upgrade chainsaw and remove a couple of kubectl/envsubst calls #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3021 +/- ##
==========================================
+ Coverage 85.75% 86.73% +0.98%
==========================================
Files 162 162
Lines 10351 8514 -1837
==========================================
- Hits 8876 7385 -1491
+ Misses 1186 839 -347
- Partials 289 290 +1 see 139 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
eddycharly
force-pushed
the
chainsaw-9
branch
from
b56e435 to
3adbc18
Compare
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
|
It works but i'm not sure if i like it or not 🤔 |
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
eddycharly
force-pushed
the
chainsaw-9
branch
from
fe2fa06 to
43128ef
Compare
|
This starts looking good, i'd like to remove |
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
eddycharly
force-pushed
the
chainsaw-9
branch
from
fae1290 to
cfc1293
Compare
eddycharly
changed the title
1 task
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
|
RealAnna
approved these changes
Feb 15, 2024
odubajDT
approved these changes
Feb 15, 2024
|
Thanks folks, resource templating wouldn't have been implemented without keptn use case and the help from Anna ! |
Bharadwajshivam28
pushed a commit
to Bharadwajshivam28/lifecycle-toolkit
that referenced
this pull request
Feb 20, 2024
…keptn#3021) Signed-off-by: Charles-Edouard Brétéché <[email protected]> Signed-off-by: shivam <[email protected]>
Vickysomtee
pushed a commit
to Vickysomtee/keptn-lifecycle-toolkit
that referenced
this pull request
Apr 23, 2024
…keptn#3021) Signed-off-by: Charles-Edouard Brétéché <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade chainsaw and remove a couple of kubectl calls.