Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Webhook creates Service, Service creates ServiceRun, ServiceRun creates Event #30

Merged
merged 20 commits into from
Sep 26, 2022
Merged

feat: Webhook creates Service, Service creates ServiceRun, ServiceRun creates Event #30

merged 20 commits into from
Sep 26, 2022

Conversation

odubajDT
Copy link
Contributor

No description provided.

thschue
thschue requested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, some small changes but then we're good to go ...

operator/controllers/service_controller.go Outdated Show resolved Hide resolved
operator/controllers/servicerun_controller.go Outdated Show resolved Hide resolved
operator/webhooks/pod_mutating_webhook.go Outdated Show resolved Hide resolved
thschue
thschue previously requested changes Sep 21, 2022
View reviewed changes
operator/webhooks/pod_mutating_webhook.go Outdated Show resolved Hide resolved
@odubajDT odubajDT changed the title ServiceController creates ServiceRun resource for each version change Webhook creates Service, Service creates ServiceRun, ServiceRun creates Event Sep 23, 2022
@odubajDT odubajDT changed the title Webhook creates Service, Service creates ServiceRun, ServiceRun creates Event feat: Webhook creates Service, Service creates ServiceRun, ServiceRun creates Event Sep 26, 2022
@odubajDT odubajDT force-pushed the mutating-webhook-logic branch from ffacd07 to 605cc6a Compare September 26, 2022 07:13
bacherfl
bacherfl previously approved these changes Sep 26, 2022
View reviewed changes
@odubajDT odubajDT requested a review from thschue September 26, 2022 08:58
odubajDT and others added 8 commits September 26, 2022 11:06
@odubajDT
working with scheduler
2948e91 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
do not delete the job for now
0c9fb1b 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
servicecontroller logic back to webhook
8cd3837 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
back to webhook
72c7dc8 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
working version with webhook creating service
929f1f7 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
small comment
634e47f 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
pr review
ea13209 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
renaming owner
436ffc9 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
add changes to scheduler to make it deployable
007425e 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
minro polishing
ecbd2d4 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
minro fixes
f7d9da3 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
generate
23d2f52 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT force-pushed the mutating-webhook-logic branch from fe5e71e to 23d2f52 Compare September 26, 2022 09:07
thschue
thschue approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 5ae58c3 into main Sep 26, 2022
This was referenced Sep 29, 2022
Closed
Closed
Closed
Closed
Closed
Merged
Merged
@thschue thschue deleted the mutating-webhook-logic branch October 13, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thschue thschue thschue approved these changes

@bacherfl bacherfl bacherfl left review comments

@thisthat thisthat Awaiting requested review from thisthat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odubajDT @bacherfl @thschue