Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate integration to chainsaw (part 1) #2973

Merged
merged 8 commits into from
Feb 7, 2024

Conversation

eddycharly
Copy link
Contributor

Migrate integration to chainsaw (part 1).

@eddycharly eddycharly requested a review from a team as a code owner February 6, 2024 21:27
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a43f429) 85.77% compared to head (f8ecac0) 85.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2973      +/-   ##
==========================================
+ Coverage   85.77%   85.82%   +0.04%     
==========================================
  Files         162      162              
  Lines       10351    10351              
==========================================
+ Hits         8879     8884       +5     
+ Misses       1184     1180       -4     
+ Partials      288      287       -1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 57.06% <ø> (+0.33%) ⬆️
lifecycle-operator 85.28% <ø> (ø)
metrics-operator 87.63% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Charles-Edouard Brétéché <[email protected]>
RealAnna
RealAnna previously approved these changes Feb 7, 2024
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eddycharly and others added 2 commits February 7, 2024 14:33
Co-authored-by: RealAnna <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
@eddycharly eddycharly requested a review from RealAnna February 7, 2024 13:44
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@RealAnna RealAnna merged commit b9b2418 into keptn:main Feb 7, 2024
34 checks passed
@eddycharly eddycharly deleted the chainsaw-4 branch February 7, 2024 15:26
Bharadwajshivam28 pushed a commit to Bharadwajshivam28/lifecycle-toolkit that referenced this pull request Feb 20, 2024
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Co-authored-by: RealAnna <[email protected]>
Signed-off-by: shivam <[email protected]>
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Co-authored-by: RealAnna <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants