Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add KeptnApp migration script #2959

Merged
merged 14 commits into from
Feb 6, 2024
Merged

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Feb 5, 2024

added basic conversion code to generate app context from an old keptn app

https://github.com/keptn/lifecycle-toolkit/tree/main/lifecycle-operator/converter is added in this pr so the
link checks fail

@RealAnna RealAnna force-pushed the feat/create-migration-script branch from 7d32252 to 3b352da Compare February 5, 2024 14:31
@RealAnna RealAnna force-pushed the feat/create-migration-script branch from fa0d02f to d254657 Compare February 5, 2024 15:01
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 5, 2024
@RealAnna RealAnna marked this pull request as ready for review February 5, 2024 15:02
@RealAnna RealAnna requested review from a team as code owners February 5, 2024 15:02
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (45a56d1) 87.14% compared to head (a19dc57) 85.85%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2959      +/-   ##
==========================================
- Coverage   87.14%   85.85%   -1.29%     
==========================================
  Files         107      162      +55     
  Lines        6767    10335    +3568     
==========================================
+ Hits         5897     8873    +2976     
- Misses        719     1174     +455     
- Partials      151      288     +137     
Files Coverage Δ
lifecycle-operator/converter/convert_app.go 75.32% <75.32%> (ø)

... and 54 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (?)
component-tests 55.80% <ø> (ø)
lifecycle-operator 85.49% <75.32%> (-0.13%) ⬇️
metrics-operator 87.63% <ø> (?)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: RealAnna <[email protected]>
@RealAnna RealAnna marked this pull request as draft February 5, 2024 15:13
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
@RealAnna RealAnna marked this pull request as ready for review February 5, 2024 16:08
StackScribe
StackScribe previously approved these changes Feb 6, 2024
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the docs. I left a couple little suggestions for you to consider.
And yeah, probably not the most essential tool ever but it does prevent a lot of careless copy/paste errors so why not?

RealAnna and others added 2 commits February 6, 2024 07:37
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: RealAnna <[email protected]>
@mowies mowies changed the title chore: add a converter script chore: add KeptnApp migration script Feb 6, 2024
mowies
mowies previously requested changes Feb 6, 2024
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the converter folder to the make unit-test command

@RealAnna RealAnna force-pushed the feat/create-migration-script branch from 62c08c5 to 01a63d9 Compare February 6, 2024 09:53
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mowies mowies merged commit 7311422 into main Feb 6, 2024
39 of 42 checks passed
@mowies mowies deleted the feat/create-migration-script branch February 6, 2024 13:47
Bharadwajshivam28 pushed a commit to Bharadwajshivam28/lifecycle-toolkit that referenced this pull request Feb 20, 2024
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants