Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adapt day 2 operations guide #2936

Merged
merged 15 commits into from
Feb 5, 2024
Merged

docs: adapt day 2 operations guide #2936

merged 15 commits into from
Feb 5, 2024

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Feb 1, 2024

Closes #2883

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 1, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 1, 2024
View reviewed changes
docs/docs/use-cases/assets/new-deployment.yaml Dismissed Show dismissed Hide dismissed
docs/docs/use-cases/assets/new-deployment.yaml Dismissed Show dismissed Hide dismissed
@bacherfl bacherfl marked this pull request as ready for review February 1, 2024 13:51
@bacherfl bacherfl requested review from a team as code owners February 1, 2024 13:51
@bacherfl @mowies
Apply suggestions from code review
9706e20 
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
StackScribe
StackScribe reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Fix the indentation of the code blocks and a couple suggestions for the links and I'm ready to approve.

@bacherfl @mowies
Update docs/docs/use-cases/day-2-operations.md
5c3fc50 
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bacherfl bacherfl merged commit f9a72b9 into keptn:main Feb 5, 2024
11 checks passed
@bacherfl bacherfl deleted the docs/adapt-day2-guide branch February 5, 2024 13:15
Bharadwajshivam28 pushed a commit to Bharadwajshivam28/lifecycle-toolkit that referenced this pull request Feb 20, 2024
@bacherfl @mowies
@StackScribe @Bharadwajshivam28
docs: adapt day 2 operations guide (keptn#2936)
8435797 
Signed-off-by: Florian Bacher <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: shivam <[email protected]>
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@bacherfl @mowies
@StackScribe @Vickysomtee
docs: adapt day 2 operations guide (keptn#2936)
9c68b8e 
Signed-off-by: Florian Bacher <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StackScribe StackScribe StackScribe left review comments

@RealAnna RealAnna RealAnna approved these changes

@mowies mowies mowies approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update day2 operations to use KeptnAppContext
4 participants
@bacherfl @StackScribe @mowies @RealAnna