-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix auto-generated API docs having wrong metadata info #2927
Conversation
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2927 +/- ##
=======================================
Coverage 85.87% 85.88%
=======================================
Files 161 161
Lines 10252 10252
=======================================
+ Hits 8804 8805 +1
Misses 1166 1166
+ Partials 282 281 -1 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fix works 🙌🏼
but the sentence is not really a sentence 🤔
Refer to Kubernetes API documentation for fields of
metadata
.
that was the original sentence XD I will |
Signed-off-by: RealAnna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: RealAnna <[email protected]>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
…2927) Signed-off-by: RealAnna <[email protected]> Signed-off-by: Florian Bacher <[email protected]>
…2927) Signed-off-by: RealAnna <[email protected]> Signed-off-by: vickysomtee <[email protected]>
context spec metadata in crd ref now has the correct reference info, metadata for k8s now links to https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/#attaching-metadata-to-objects