chore: fix makefile lint targets #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2920 +/- ##
==========================================
- Coverage 85.82% 85.81% -0.01%
==========================================
Files 161 161
Lines 10252 10252
==========================================
- Hits 8799 8798 -1
- Misses 1170 1171 +1
Partials 283 283 see 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
mowies
reviewed
Jan 31, 2024
|
@mowies i will look at it and eventually open a follow up |
|
i'd be fine with fixing that in this PR as well, but as you like 🤷🏼 |
|
Yeah, in another PR will be better. |
RealAnna
approved these changes
Feb 1, 2024
mowies
approved these changes
Feb 1, 2024
bacherfl
pushed a commit
to bacherfl/lifecycle-controller
that referenced
this pull request
Feb 5, 2024
Signed-off-by: Florian Bacher <[email protected]>
Vickysomtee
pushed a commit
to Vickysomtee/keptn-lifecycle-toolkit
that referenced
this pull request
Apr 23, 2024
Signed-off-by: vickysomtee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix makefile lint targets.